From: Dave Hansen <haveblue@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [RFC] remove highmem_start_page
Date: Tue, 26 Oct 2004 17:30:30 -0700 [thread overview]
Message-ID: <1098837030.9408.2.camel@localhost> (raw)
In-Reply-To: <20041026172359.3059edec.akpm@osdl.org>
On Tue, 2004-10-26 at 17:23, Andrew Morton wrote:
> Dave Hansen <haveblue@us.ibm.com> wrote:
> >
> > +static inline int page_is_highmem(struct page *page)
> > +{
> > + return PageHighMem(page);
> > +}
>
> (boggle). Why not just use PageHighMem() directly?
Because I was doing another, more complex, calculation before that and
realized about PageHighMem() later on. Would have also made it easier
to fix if someone came up with a better way when I posted the patch :)
I take it you'd rather just see it called directly.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [RFC] remove highmem_start_page
Date: Tue, 26 Oct 2004 17:30:30 -0700 [thread overview]
Message-ID: <1098837030.9408.2.camel@localhost> (raw)
In-Reply-To: <20041026172359.3059edec.akpm@osdl.org>
On Tue, 2004-10-26 at 17:23, Andrew Morton wrote:
> Dave Hansen <haveblue@us.ibm.com> wrote:
> >
> > +static inline int page_is_highmem(struct page *page)
> > +{
> > + return PageHighMem(page);
> > +}
>
> (boggle). Why not just use PageHighMem() directly?
Because I was doing another, more complex, calculation before that and
realized about PageHighMem() later on. Would have also made it easier
to fix if someone came up with a better way when I posted the patch :)
I take it you'd rather just see it called directly.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-10-27 0:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-26 19:56 [RFC] remove highmem_start_page Dave Hansen
2004-10-27 0:23 ` Andrew Morton
2004-10-27 0:23 ` Andrew Morton
2004-10-27 0:30 ` Dave Hansen [this message]
2004-10-27 0:30 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098837030.9408.2.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.