From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: adaplas@pol.net
Cc: Andrew Morton <akpm@osdl.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH 8/8] fbdev: Fix broken fb_blank() implementation.
Date: Mon, 08 Nov 2004 10:52:50 +1100 [thread overview]
Message-ID: <1099871570.3884.138.camel@gaston> (raw)
In-Reply-To: <200411080723.39722.adaplas@hotpop.com>
On Mon, 2004-11-08 at 07:23 +0800, Antonino A. Daplas wrote:
> I'm not too sure about this, but I think so, it is world callable and is
> called by bust_spinlocks() at least. What about putting fbcon_blank() in the
> workqueue...? (Or perhaps unblank/blank_screen in vt.c, but the code
> in vt.c is very fragile...)
Yah. I already fixed a bunch of vt.c so nowadays, at least, we do
everything with the console sem. held, so the driver doesn't have to
care about re-entrancy, though we still can be called at irq context.
A workqueue may not be a good idea. I don't like workqueue abuse, and
sleeping > 200ms there means that whatever other driver using workqueues
will suddenly have _huge_ latencies, it's not good.
I suppose I'll stick with my timer ...
Ben.
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
prev parent reply other threads:[~2004-11-07 23:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-07 21:27 [PATCH 8/8] fbdev: Fix broken fb_blank() implementation Antonino A. Daplas
2004-11-07 21:39 ` Benjamin Herrenschmidt
2004-11-07 23:23 ` Antonino A. Daplas
2004-11-07 23:52 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1099871570.3884.138.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=adaplas@pol.net \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.