Re: [PATCH 8/8] fbdev: Fix broken fb_blank() implementation.

["Antonino A. Daplas" <adaplas@hotpop.com>]

On Monday 08 November 2004 05:39, Benjamin Herrenschmidt wrote:
> On Mon, 2004-11-08 at 05:27 +0800, Antonino A. Daplas wrote:
> > This patch fixes some of the drivers' fb_blank() implementation which got
> > the usage of the VESA_* constants incorrectly and converts them to use
> > the new FB_BLANK-* constants.
> >
> > I'm not sure if what I did is correct for all drivers, so maintainers,
> > please review.
> >
> > (Note: For most of the drivers, FB_BLANK_NORMAL is treated as
> > FB_BLANK_UNBLANK, but returns a nonzero so fbcon wi
>
> I think that on laptops, FB_BLANK_NORMAL could lower the backlight to 0
> (without disabling the panel, which requires more time)... I'll look
> into this, in the meantime, your patch is fine.

Yes, I was not too sure what to do with FB_BLANK_NORMAL not just for drivers
with backlights, so I took the safe route (unblank but do a soft_blank).

>
> BTW, what is the current status, can we use msleep in blank yet ? I
> think we can still have unblank() called by printk at interrupt time
> right ? I'd like to msleep in there rather than playing my games with
> a timer ...
>

I'm not too sure about this, but I think so, it is world callable and is
called by bust_spinlocks() at least. What about putting fbcon_blank() in the
workqueue...? (Or perhaps unblank/blank_screen in vt.c, but the code
in vt.c is very fragile...)

Tony





-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click