From: Luck, Tony <tony.luck@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: arch/x86/lib/copy_mc.c:30:1: warning: no previous prototype for 'copy_mc_fragile_handle_tail'
Date: Wed, 09 Jun 2021 23:55:30 +0000 [thread overview]
Message-ID: <10c9fdc0ace04013b7d4999643aa8b21@intel.com> (raw)
In-Reply-To: <CAPcyv4jAkutNExqao0Q1HYL-pQxrSbAN3F5N9Uj=09KDa_uynw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
> This routine is only ever called from ASM code, so the fact that there
> is no C declaration is expected.
Does the asm code really need to call back into C?
Could you just have the asm code do "jmp .L_read_trailing_bytes" (might need to only do that if %ecx is non-zero)?
-Tony
WARNING: multiple messages have this Message-ID (diff)
From: "Luck, Tony" <tony.luck@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>, lkp <lkp@intel.com>
Cc: "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@suse.de>
Subject: RE: arch/x86/lib/copy_mc.c:30:1: warning: no previous prototype for 'copy_mc_fragile_handle_tail'
Date: Wed, 9 Jun 2021 23:55:30 +0000 [thread overview]
Message-ID: <10c9fdc0ace04013b7d4999643aa8b21@intel.com> (raw)
In-Reply-To: <CAPcyv4jAkutNExqao0Q1HYL-pQxrSbAN3F5N9Uj=09KDa_uynw@mail.gmail.com>
> This routine is only ever called from ASM code, so the fact that there
> is no C declaration is expected.
Does the asm code really need to call back into C?
Could you just have the asm code do "jmp .L_read_trailing_bytes" (might need to only do that if %ecx is non-zero)?
-Tony
next prev parent reply other threads:[~2021-06-09 23:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 22:43 arch/x86/lib/copy_mc.c:30:1: warning: no previous prototype for 'copy_mc_fragile_handle_tail' kernel test robot
2021-06-09 22:43 ` kernel test robot
2021-06-09 23:43 ` Dan Williams
2021-06-09 23:43 ` Dan Williams
2021-06-09 23:55 ` Luck, Tony [this message]
2021-06-09 23:55 ` Luck, Tony
2021-06-10 0:13 ` Dan Williams
2021-06-10 0:13 ` Dan Williams
-- strict thread matches above, loose matches on Subject: below --
2021-04-28 8:32 kernel test robot
2021-04-28 8:32 ` kernel test robot
2021-03-30 18:10 kernel test robot
2021-03-30 18:10 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10c9fdc0ace04013b7d4999643aa8b21@intel.com \
--to=tony.luck@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.