Re: [Buildroot] [PATCH] packge/libabseil-cpp: bump to version 20230125.0

[Michael Nosthoff via buildroot <buildroot@buildroot.org>]

Hi,

On Sunday, February 19, 2023 22:02 CET, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Hello Michael,
> 
> On Sat, 18 Feb 2023 12:48:37 +0100
> Michael Nosthoff via buildroot <buildroot@buildroot.org> wrote:
> 
> > libabseil now depends on c++14 and gcc >= 7.3.1 [0][1]
> > 
> > [0] https://github.com/abseil/abseil-cpp/releases/tag/20230125.0
> > [1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md
> > 
> > Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> > ---
> > 
> > Note:
> > I'm not sure if the BR2_TOOLCHAIN_GCC_AT_LEAST_7 dependency is sufficient.
> > But I don't think we have a more version specific Flag available?
> 
> We don't have more specific blind options than 7.x, 8.x, etc. to
> describe a gcc dependency.
> 
> >  package/grpc/Config.in                   | 6 +++---
> >  package/libabseil-cpp/Config.in          | 6 +++---
> >  package/libabseil-cpp/libabseil-cpp.hash | 2 +-
> >  package/libabseil-cpp/libabseil-cpp.mk   | 6 +++---
> >  4 files changed, 10 insertions(+), 10 deletions(-)
> 
> I'm afraid this is not sufficient. Indeed, you need to look at the
> reverse dependencies of GRPC for example.
> 
> So, package/falcosecurity-libs needs to be adjusted, then
> package/sysdig as well, and also the BR2_PACKAGE_COLLECTD_GRPC option
> from package/collectd.
> 

good point. since grpc now also only has "officially support for gcc 7.3+" I would then first bump grpc with all it dependencies and then resubmit this patch.

https://github.com/grpc/grpc/blob/master/src/cpp/README.md

> Could you have a look into this, and submit an updated version?
> 
> Thanks a lot!
> 
> Thomas

Regards,
Michael

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot