From: Len Brown <len.brown@intel.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Adrian Bunk <bunk@stusta.de>, Chris Wright <chrisw@osdl.org>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Stian Jordet <stian_web@jordet.nu>
Subject: Re: 2.6.10-rc2 doesn't boot (if no floppy device)
Date: 23 Nov 2004 02:06:26 -0500 [thread overview]
Message-ID: <1101193585.20006.533.camel@d845pe> (raw)
In-Reply-To: <Pine.LNX.4.58.0411222048120.20993@ppc970.osdl.org>
On Mon, 2004-11-22 at 23:57, Linus Torvalds wrote:
>
> On Mon, 22 Nov 2004, Linus Torvalds wrote:
> >
> Len, how about this patch - it re-enables the link disable and then
> re-codes the ELCR setting to match.
>
> Basically it just computes the new ELCR: if acpi_noirq is set, it
> leaves it at the old value, otherwise it zeroes it - and in both cases
> it fixes the SCI entry.
> Your argument for doing this ended up being convincing, so the only
> difference between this and your debug patch is really just the
> obvious organizational ones, and the test for "acpi_noirq", which I
> think is needed (since if acpi_noirq is set, we're not going to
> disable and re-enable the PCI interrupts, so we'll just have to trust
> ELCR).
I think your use of acpi_noirq in acpi_pic_sci_set_trigger() was clever
-- maybe more clever than the name of the routine suggests -- but it
looks correct.
thanks for restoring pci_link.c
-Len
next prev parent reply other threads:[~2004-11-23 7:08 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-15 2:49 Linux 2.6.10-rc2 Linus Torvalds
2004-11-15 4:07 ` 2.6.10-rc2 doesn't boot Adrian Bunk
2004-11-15 4:48 ` Linus Torvalds
2004-11-15 5:29 ` Adrian Bunk
2004-11-15 23:27 ` Chris Wright
2004-11-15 23:58 ` Andrew Morton
2004-11-18 23:14 ` 2.6.10-rc2 doesn't boot (if no floppy device) Len Brown
2004-11-19 7:09 ` Chris Wright
2004-11-20 9:02 ` Len Brown
2004-11-20 12:40 ` Adrian Bunk
2004-11-20 18:28 ` Linus Torvalds
2004-11-20 19:10 ` Linus Torvalds
2004-11-22 19:55 ` Len Brown
2004-11-24 16:26 ` Alan Cox
2004-11-21 16:29 ` Adrian Bunk
2004-11-22 19:29 ` Len Brown
2004-11-22 20:02 ` Linus Torvalds
2004-11-22 20:10 ` Linus Torvalds
2004-11-22 20:38 ` Len Brown
2004-11-23 2:45 ` Linus Torvalds
2004-11-23 4:57 ` Linus Torvalds
2004-11-23 7:06 ` Len Brown [this message]
2004-11-23 20:13 ` Stian Jordet
2004-11-23 2:00 ` Chris Wright
2004-11-22 18:28 ` Len Brown
2004-11-23 0:46 ` Adrian Bunk
2004-11-23 1:07 ` why use ACPI (Re: 2.6.10-rc2 doesn't boot (if no floppy device)) Len Brown
2004-11-23 1:23 ` Dave Jones
2004-11-23 1:52 ` Adrian Bunk
2004-11-23 1:37 ` Adrian Bunk
2004-11-23 2:47 ` Len Brown
2004-11-23 2:50 ` Dave Jones
2004-11-23 3:13 ` Gene Heskett
2004-11-23 3:45 ` Dave Jones
2004-11-20 16:41 ` 2.6.10-rc2 doesn't boot (if no floppy device) Linus Torvalds
2004-11-22 19:07 ` Len Brown
2004-11-22 19:23 ` Linus Torvalds
2004-11-22 20:24 ` Len Brown
2004-11-22 20:31 ` Linus Torvalds
2004-11-22 20:36 ` Linus Torvalds
2004-11-22 20:54 ` Len Brown
2004-11-22 20:51 ` Len Brown
2004-11-23 1:58 ` Chris Wright
2004-11-19 13:47 ` Adrian Bunk
2004-11-23 1:57 ` Chris Wright
2004-11-15 7:25 ` 2.6.10-rc2 doesn't boot Andrew Morton
2004-11-15 10:26 ` Linux 2.6.10-rc2 Russell King
2004-11-15 11:24 ` Ben Dooks
2004-11-15 11:55 ` Nick Piggin
2004-11-15 20:20 ` Andrew Morton
2004-11-16 0:29 ` Linux 2.6.10-rc2 [dvb-bt8xx unload oops] Eyal Lebedinsky
2004-11-16 9:57 ` Eyal Lebedinsky
2004-11-17 23:17 ` Eyal Lebedinsky
2004-11-16 7:55 ` Linux 2.6.10-rc2 SAVAGEFB startup crash Philipp Matthias Hahn
2004-11-16 8:17 ` Colin Leroy
2004-11-16 12:43 ` Antonino A. Daplas
2004-11-16 17:27 ` Philipp Matthias Hahn
2004-11-16 21:20 ` Antonino A. Daplas
2004-11-17 11:55 ` Philipp Matthias Hahn
2004-11-16 21:43 ` Antonino A. Daplas
2004-11-16 16:25 ` Linux 2.6.10-rc2 Guido Guenther
2004-11-17 15:54 ` Andrew Walrond
2004-11-17 15:54 ` Andrew Walrond
[not found] ` <Pine.LNX.4.58.0411170802500.2222@ppc970.osdl.org>
2004-11-17 19:17 ` Andrew Walrond
2004-11-17 22:33 ` Andrew Walrond
2004-11-17 23:12 ` Linus Torvalds
2004-11-17 23:37 ` Andrew Walrond
2004-11-18 0:12 ` Antonino A. Daplas
2004-11-19 9:06 ` Guido Guenther
2004-11-18 0:01 ` Antonino A. Daplas
2004-11-18 10:19 ` Geert Uytterhoeven
2004-11-17 16:58 ` Linux 2.6.10-rc2 OOPS on boot with 3ware + reiserfs Vladimir B. Savkin
[not found] ` <Pine.LNX.4.58.0411170935040.2222@ppc970.osdl.org>
[not found] ` <20041118103526.GC26240@suse.de>
2004-11-18 16:02 ` Vladimir B. Savkin
2004-11-18 18:39 ` Jens Axboe
2004-11-18 19:10 ` Jens Axboe
2004-11-18 19:22 ` James Bottomley
2004-11-18 21:32 ` Jens Axboe
2004-11-18 21:39 ` James Bottomley
2004-11-19 8:40 ` Jens Axboe
2004-11-17 19:32 ` Linux 2.6.10-rc2 start_udev very slow Andrew Walrond
2004-11-17 23:13 ` Greg KH
2004-12-16 15:56 ` Greg KH
2004-12-16 20:57 ` Andrew Walrond
2004-12-16 21:11 ` Greg KH
2004-12-16 21:20 ` Andrew Walrond
2004-12-16 21:46 ` Greg KH
2004-11-18 17:26 ` Linux 2.6.10-rc2 Vladimir B. Savkin
2004-11-18 17:59 ` Linus Torvalds
2004-11-18 18:01 ` Matthew Wilcox
2004-11-19 8:43 ` Vladimir B. Savkin
[not found] <F7DC2337C7631D4386A2DF6E8FB22B30020B7225@hdsmsx401.amr.corp.intel.com>
2004-11-19 15:57 ` 2.6.10-rc2 doesn't boot (if no floppy device) Adrian Bunk
2004-11-19 17:36 ` Linus Torvalds
2004-11-19 18:51 ` Len Brown
2004-11-19 19:11 ` Adrian Bunk
2004-11-19 21:05 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101193585.20006.533.camel@d845pe \
--to=len.brown@intel.com \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=bunk@stusta.de \
--cc=chrisw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stian_web@jordet.nu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.