All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Brownell <david-b@pacbell.net>
Cc: Colin Leroy <colin.lkml@colino.net>,
	Linux-USB <linux-usb-devel@lists.sourceforge.net>,
	Colin Leroy <colin@colino.net>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Greg KH <greg@kroah.com>, Andrew Morton <akpm@osdl.org>
Subject: Re: [linux-usb-devel] [PATCH] Ohci-hcd: fix endless loop (second take)
Date: Sat, 27 Nov 2004 09:12:10 +1100	[thread overview]
Message-ID: <1101507130.28047.29.camel@gaston> (raw)
In-Reply-To: <200411260957.52971.david-b@pacbell.net>

On Fri, 2004-11-26 at 09:57 -0800, David Brownell wrote:
> On Friday 26 November 2004 09:37, Colin Leroy wrote:
> > On 26 Nov 2004 at 09h11, David Brownell wrote:
> > > This isn't a good patch either... maybe your best
> > > bet would be to find out why the IRQs stopped getting
> > > delivered.
> > 
> > It's probably a linux-wlan-ng issue... 
> 
> I suspect PPC resume issues myself.

Colin, you didn't tell us which controller it was ? The NEC one is a
totally normal off-the-shelves controller coming out of D3. The Apple
ones are a bit special tho.
> 
> As expected, if IRQs aren't arriving.  Though you
> may not be using the latest kernel; it's supposed
> to give warnings about IRQ delivery problems after
> resume too, not just on initial startup.

It could be a problem in the code restarting the clocks to the USB cell
in KL (provided it's one of these controller and not the NEC), that
would need some more delay before restarting things...

> I'm not expert in PPC IRQ delivery, which is where the
> root cause of this problem seems to live.  We all have
> places where we need help!

There is nothing fancy with PPC IRQ delivery. IRQs work on wakeup for
everybody or nobody. It's a problem with the USB chip. (There is no
fancy firmware IRQ routing thing, etc... every device is physically
wired to one of the about 128 IRQ lines of the MPIC).

Ben.



  reply	other threads:[~2004-11-26 22:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-26 10:30 [PATCH] Ohci-hcd: fix endless loop (second take) Colin Leroy
2004-11-26 17:28 ` [linux-usb-devel] " David Brownell
2004-11-26 17:37   ` Colin Leroy
2004-11-26 17:57     ` David Brownell
2004-11-26 22:12       ` Benjamin Herrenschmidt [this message]
2004-11-29  8:04         ` Colin Leroy
2004-11-29 22:26           ` Benjamin Herrenschmidt
2004-11-29 22:34             ` Colin Leroy
2004-11-29 22:43               ` Benjamin Herrenschmidt
2004-11-30  0:41                 ` David Brownell
2004-11-26 18:46   ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1101507130.28047.29.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=akpm@osdl.org \
    --cc=colin.lkml@colino.net \
    --cc=colin@colino.net \
    --cc=david-b@pacbell.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.