From: David Brownell <david-b@pacbell.net>
To: linux-usb-devel@lists.sourceforge.net
Cc: Colin Leroy <colin@colino.net>,
Linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Greg KH <greg@kroah.com>, Andrew Morton <akpm@osdl.org>
Subject: Re: [linux-usb-devel] [PATCH] Ohci-hcd: fix endless loop (second take)
Date: Fri, 26 Nov 2004 09:28:17 -0800 [thread overview]
Message-ID: <200411260928.18135.david-b@pacbell.net> (raw)
In-Reply-To: <20041126113021.135e79df@pirandello>
On Friday 26 November 2004 02:30, Colin Leroy wrote:
> @@ -375,6 +375,11 @@
> spin_unlock_irqrestore (&ohci->lock, flags);
> set_current_state (TASK_UNINTERRUPTIBLE);
> schedule_timeout (1);
> + if (limit < 1000) {
> + ohci_warn (ohci, "Can't recover, restarting.\n");
> + ohci_restart(ohci);
> + return;
> + }
So instead of waiting a moment for the ED to finish
its normal processing and move from state ED_UNLINK
into ED_IDLE, you want to always clobber the whole
USB device tree attached to that bus? That'd happen
quite routinely.
This isn't a good patch either... maybe your best
bet would be to find out why the IRQs stopped getting
delivered.
- Dave
next prev parent reply other threads:[~2004-11-26 19:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-26 10:30 [PATCH] Ohci-hcd: fix endless loop (second take) Colin Leroy
2004-11-26 17:28 ` David Brownell [this message]
2004-11-26 17:37 ` [linux-usb-devel] " Colin Leroy
2004-11-26 17:57 ` David Brownell
2004-11-26 22:12 ` Benjamin Herrenschmidt
2004-11-29 8:04 ` Colin Leroy
2004-11-29 22:26 ` Benjamin Herrenschmidt
2004-11-29 22:34 ` Colin Leroy
2004-11-29 22:43 ` Benjamin Herrenschmidt
2004-11-30 0:41 ` David Brownell
2004-11-26 18:46 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411260928.18135.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=Linux-kernel@vger.kernel.org \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=colin@colino.net \
--cc=greg@kroah.com \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.