From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: devel@driverdev.osuosl.org, Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
Stephen Hemminger <stephen@networkplumber.org>,
linux-m68k@lists.linux-m68k.org,
intel-wired-lan@lists.osuosl.org,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Mirko Lindner <mlindner@marvell.com>
Subject: Re: [B.A.T.M.A.N.] [PATCH net-next] net: Remove usage of net_device last_rx member
Date: Wed, 18 Jan 2017 09:39:52 -0800 [thread overview]
Message-ID: <11021.1484761192@famine> (raw)
In-Reply-To: <20170118164501.1934-1-tklauser@distanz.ch>
Tobias Klauser <tklauser@distanz.ch> wrote:
>The network stack no longer uses the last_rx member of struct net_device
>since the bonding driver switched to use its own private last_rx in
>commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()").
>
>However, some drivers still (ab)use the field for their own purposes and
>some driver just update it without actually using it.
>
>Previously, there was an accompanying comment for the last_rx member
>added in commit 4dc89133f49b ("net: add a comment on netdev->last_rx")
>which asked drivers not to update is, unless really needed. However,
>this commend was removed in commit f8ff080dacec ("bonding: remove
>useless updating of slave->dev->last_rx"), so some drivers added later
>on still did update last_rx.
>
>Remove all usage of last_rx and switch three drivers (sky2, atp and
>smc91c92_cs) which actually read and write it to use their own private
>copy in netdev_priv.
>
>Compile-tested with allyesconfig and allmodconfig on x86 and arm.
Reviewed-by: Jay Vosburgh <jay.vosburgh@canonical.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next] net: Remove usage of net_device last_rx member
Date: Wed, 18 Jan 2017 09:39:52 -0800 [thread overview]
Message-ID: <11021.1484761192@famine> (raw)
In-Reply-To: <20170118164501.1934-1-tklauser@distanz.ch>
Tobias Klauser <tklauser@distanz.ch> wrote:
>The network stack no longer uses the last_rx member of struct net_device
>since the bonding driver switched to use its own private last_rx in
>commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()").
>
>However, some drivers still (ab)use the field for their own purposes and
>some driver just update it without actually using it.
>
>Previously, there was an accompanying comment for the last_rx member
>added in commit 4dc89133f49b ("net: add a comment on netdev->last_rx")
>which asked drivers not to update is, unless really needed. However,
>this commend was removed in commit f8ff080dacec ("bonding: remove
>useless updating of slave->dev->last_rx"), so some drivers added later
>on still did update last_rx.
>
>Remove all usage of last_rx and switch three drivers (sky2, atp and
>smc91c92_cs) which actually read and write it to use their own private
>copy in netdev_priv.
>
>Compile-tested with allyesconfig and allmodconfig on x86 and arm.
Reviewed-by: Jay Vosburgh <jay.vosburgh@canonical.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: devel@driverdev.osuosl.org, Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
linux-m68k@lists.linux-m68k.org,
intel-wired-lan@lists.osuosl.org,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Mirko Lindner <mlindner@marvell.com>
Subject: Re: [PATCH net-next] net: Remove usage of net_device last_rx member
Date: Wed, 18 Jan 2017 09:39:52 -0800 [thread overview]
Message-ID: <11021.1484761192@famine> (raw)
In-Reply-To: <20170118164501.1934-1-tklauser@distanz.ch>
Tobias Klauser <tklauser@distanz.ch> wrote:
>The network stack no longer uses the last_rx member of struct net_device
>since the bonding driver switched to use its own private last_rx in
>commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()").
>
>However, some drivers still (ab)use the field for their own purposes and
>some driver just update it without actually using it.
>
>Previously, there was an accompanying comment for the last_rx member
>added in commit 4dc89133f49b ("net: add a comment on netdev->last_rx")
>which asked drivers not to update is, unless really needed. However,
>this commend was removed in commit f8ff080dacec ("bonding: remove
>useless updating of slave->dev->last_rx"), so some drivers added later
>on still did update last_rx.
>
>Remove all usage of last_rx and switch three drivers (sky2, atp and
>smc91c92_cs) which actually read and write it to use their own private
>copy in netdev_priv.
>
>Compile-tested with allyesconfig and allmodconfig on x86 and arm.
Reviewed-by: Jay Vosburgh <jay.vosburgh@canonical.com>
next prev parent reply other threads:[~2017-01-18 17:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 16:45 [B.A.T.M.A.N.] [PATCH net-next] net: Remove usage of net_device last_rx member Tobias Klauser
2017-01-18 16:45 ` Tobias Klauser
2017-01-18 16:45 ` [Intel-wired-lan] " Tobias Klauser
2017-01-18 17:23 ` Eric Dumazet
2017-01-18 17:23 ` [B.A.T.M.A.N.] " Eric Dumazet
2017-01-18 17:23 ` Eric Dumazet
2017-01-18 17:23 ` [Intel-wired-lan] " Eric Dumazet
2017-01-18 17:39 ` Jay Vosburgh [this message]
2017-01-18 17:39 ` Jay Vosburgh
2017-01-18 17:39 ` [Intel-wired-lan] " Jay Vosburgh
2017-01-18 17:39 ` Jay Vosburgh
2017-01-18 22:27 ` David Miller
2017-01-18 22:27 ` [B.A.T.M.A.N.] " David Miller
2017-01-18 22:27 ` David Miller
2017-01-18 22:27 ` [Intel-wired-lan] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11021.1484761192@famine \
--to=jay.vosburgh@canonical.com \
--cc=andy@greyhouse.net \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=devel@driverdev.osuosl.org \
--cc=eric.dumazet@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=tklauser@distanz.ch \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.