From: Dave Hansen <haveblue@us.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [patch] [RFC] move 'struct page' into its own header
Date: Thu, 16 Dec 2004 14:46:01 -0800 [thread overview]
Message-ID: <1103237161.13614.2388.camel@localhost> (raw)
In-Reply-To: <20041216222513.GA15451@infradead.org>
On Thu, 2004-12-16 at 14:25, Christoph Hellwig wrote:
> On Thu, Dec 16, 2004 at 02:04:15PM -0800, Dave Hansen wrote:
> > So, put 'struct page' into structpage.h, along with a nasty comment
> > telling everyone to keep their grubby mitts out of the file.
> What about calling it page.h? structfoo.h sounds like a really strange
> name.
The only reason I didn't do that is that there is already an
asm/page.h. But, linux/page.h would be a fine name, too.
> And while you're at it page-flags.h should probably be merged into
> it.
The only tricky part might be page-flags.h includes asm/pgtable.h, which
(on i386) includes linux/slab.h, which includes asm/page.h. This might
somewhat restrict the number of places that the new header can be
included. As it stands, it can be included (and get you a full
definition of struct page) almost anywhere.
But, I'm not quite sure why page-flags.h even needs asm/pgtable.h. I
just took it out in i386, and it still compiles just fine. Maybe it is
needed for another architecture.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [patch] [RFC] move 'struct page' into its own header
Date: Thu, 16 Dec 2004 14:46:01 -0800 [thread overview]
Message-ID: <1103237161.13614.2388.camel@localhost> (raw)
In-Reply-To: <20041216222513.GA15451@infradead.org>
On Thu, 2004-12-16 at 14:25, Christoph Hellwig wrote:
> On Thu, Dec 16, 2004 at 02:04:15PM -0800, Dave Hansen wrote:
> > So, put 'struct page' into structpage.h, along with a nasty comment
> > telling everyone to keep their grubby mitts out of the file.
> What about calling it page.h? structfoo.h sounds like a really strange
> name.
The only reason I didn't do that is that there is already an
asm/page.h. But, linux/page.h would be a fine name, too.
> And while you're at it page-flags.h should probably be merged into
> it.
The only tricky part might be page-flags.h includes asm/pgtable.h, which
(on i386) includes linux/slab.h, which includes asm/page.h. This might
somewhat restrict the number of places that the new header can be
included. As it stands, it can be included (and get you a full
definition of struct page) almost anywhere.
But, I'm not quite sure why page-flags.h even needs asm/pgtable.h. I
just took it out in i386, and it still compiles just fine. Maybe it is
needed for another architecture.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-12-16 22:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-16 22:04 [patch] [RFC] move 'struct page' into its own header Dave Hansen
2004-12-16 22:04 ` Dave Hansen
2004-12-16 22:25 ` Christoph Hellwig
2004-12-16 22:25 ` Christoph Hellwig
2004-12-16 22:46 ` Dave Hansen [this message]
2004-12-16 22:46 ` Dave Hansen
2004-12-16 23:06 ` Russell King
2004-12-16 23:06 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1103237161.13614.2388.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.