From: Kukjin Kim <kgene@kernel.org>
To: 'Padmavathi Venna' <padma.v@samsung.com>,
linux-samsung-soc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, padma.kvr@gmail.com
Cc: sbkim73@samsung.com, broonie@kernel.org, dianders@chromium.org,
abrestic@chromium.org, vinod.koul@intel.com
Subject: RE: [PATCH 2/2] ARM: dts: Add DMA controller node info on Exynos5420.
Date: Wed, 14 Aug 2013 18:45:28 +0900 [thread overview]
Message-ID: <110501ce98d3$0288bc40$079a34c0$@org> (raw)
In-Reply-To: <1373458449-19039-3-git-send-email-padma.v@samsung.com>
Padmavathi Venna wrote:
>
> Exynos5420 has one separate DMA controller for I2S0 and PCM0. This patch
> adds the same node on exynos5420 dtsi and adds the DMA clk info for the
> remaining DMA controllers.
>
> Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 33
+++++++++++++++++++++++++++++++++
> 1 files changed, 33 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi
> index a84f5f1..7035a4b 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -137,6 +137,39 @@
> interrupts = <0 47 0>;
> };
>
> + amba {
> + pdma0: pdma@121A0000 {
> + clocks = <&clock 362>;
> + clock-names = "apb_pclk";
> + };
> +
> + pdma1: pdma@121B0000 {
> + clocks = <&clock 363>;
> + clock-names = "apb_pclk";
> + };
> +
> + mdma0: mdma@10800000 {
> + clocks = <&clock 473>;
> + clock-names = "apb_pclk";
> + };
> +
> + mdma1: mdma@11C10000 {
> + clocks = <&clock 442>;
> + clock-names = "apb_pclk";
> + };
> +
> + adma: adma@03880000 {
> + compatible = "arm,pl330", "arm,primecell";
> + reg = <0x03880000 0x1000>;
> + interrupts = <0 110 0>;
> + clocks = <&clock_audss EXYNOS_ADMA>;
> + clock-names = "apb_pclk";
> + #dma-cells = <1>;
> + #dma-channels = <6>;
> + #dma-requests = <16>;
> + };
> + };
> +
> serial@12C00000 {
> clocks = <&clock 257>, <&clock 128>;
> clock-names = "uart", "clk_uart_baud0";
> --
> 1.7.4.4
See my comments on 1st patch and you need to re-spin for dmac on exynos5420.
Thanks,
Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: Add DMA controller node info on Exynos5420.
Date: Wed, 14 Aug 2013 18:45:28 +0900 [thread overview]
Message-ID: <110501ce98d3$0288bc40$079a34c0$@org> (raw)
In-Reply-To: <1373458449-19039-3-git-send-email-padma.v@samsung.com>
Padmavathi Venna wrote:
>
> Exynos5420 has one separate DMA controller for I2S0 and PCM0. This patch
> adds the same node on exynos5420 dtsi and adds the DMA clk info for the
> remaining DMA controllers.
>
> Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 33
+++++++++++++++++++++++++++++++++
> 1 files changed, 33 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi
> index a84f5f1..7035a4b 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -137,6 +137,39 @@
> interrupts = <0 47 0>;
> };
>
> + amba {
> + pdma0: pdma at 121A0000 {
> + clocks = <&clock 362>;
> + clock-names = "apb_pclk";
> + };
> +
> + pdma1: pdma at 121B0000 {
> + clocks = <&clock 363>;
> + clock-names = "apb_pclk";
> + };
> +
> + mdma0: mdma at 10800000 {
> + clocks = <&clock 473>;
> + clock-names = "apb_pclk";
> + };
> +
> + mdma1: mdma at 11C10000 {
> + clocks = <&clock 442>;
> + clock-names = "apb_pclk";
> + };
> +
> + adma: adma at 03880000 {
> + compatible = "arm,pl330", "arm,primecell";
> + reg = <0x03880000 0x1000>;
> + interrupts = <0 110 0>;
> + clocks = <&clock_audss EXYNOS_ADMA>;
> + clock-names = "apb_pclk";
> + #dma-cells = <1>;
> + #dma-channels = <6>;
> + #dma-requests = <16>;
> + };
> + };
> +
> serial at 12C00000 {
> clocks = <&clock 257>, <&clock 128>;
> clock-names = "uart", "clk_uart_baud0";
> --
> 1.7.4.4
See my comments on 1st patch and you need to re-spin for dmac on exynos5420.
Thanks,
Kukjin
next prev parent reply other threads:[~2013-08-14 9:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 12:14 [PATCH 0/2] Move comon DMA nodes to exynos5.dtsi and Padmavathi Venna
2013-07-10 12:14 ` Padmavathi Venna
2013-07-10 12:14 ` [PATCH 1/2] ARM: dts: Move the common DMA controller nodes to exynos5.dtsi Padmavathi Venna
2013-07-10 12:14 ` Padmavathi Venna
2013-08-14 9:44 ` Kukjin Kim
2013-08-14 9:44 ` Kukjin Kim
2013-07-10 12:14 ` [PATCH 2/2] ARM: dts: Add DMA controller node info on Exynos5420 Padmavathi Venna
2013-07-10 12:14 ` Padmavathi Venna
2013-08-14 9:45 ` Kukjin Kim [this message]
2013-08-14 9:45 ` Kukjin Kim
2013-08-12 10:18 ` [PATCH 0/2] Move comon DMA nodes to exynos5.dtsi and Padma Venkat
2013-08-12 10:18 ` Padma Venkat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='110501ce98d3$0288bc40$079a34c0$@org' \
--to=kgene@kernel.org \
--cc=abrestic@chromium.org \
--cc=broonie@kernel.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
--cc=sbkim73@samsung.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.