From: David Woodhouse <dwmw2@infradead.org>
To: linux-arch@vger.kernel.org
Subject: TASK_SIZE is variable.
Date: Tue, 25 Jan 2005 22:26:52 +0000 [thread overview]
Message-ID: <1106692012.6480.158.camel@localhost.localdomain> (raw)
Bad things can happen if a 32-bit process is the last user of a 64-bit
mm. TASK_SIZE isn't a constant, and we can end up clearing page tables
only up to the 32-bit TASK_SIZE instead of all the way. We should
probably double-check every instance of TASK_SIZE or USER_PTRS_PER_PGD
for this kind of problem.
We should also double-check that MM_VM_SIZE() and other such things are
correctly defined on all architectures. I already fixed ppc64 which let
it stay as TASK_SIZE, and hence dependent on the _current_ context
instead of the mm in the argument.
--- mm/mmap.c.orig 2005-01-25 22:23:02.030427272 +0000
+++ mm/mmap.c 2005-01-25 22:23:55.627279312 +0000
@@ -1612,8 +1612,8 @@ static void free_pgtables(struct mmu_gat
unsigned long last = end + PGDIR_SIZE - 1;
struct mm_struct *mm = tlb->mm;
- if (last > TASK_SIZE || last < end)
- last = TASK_SIZE;
+ if (last > MM_VM_SIZE(mm) || last < end)
+ last = MM_VM_SIZE(mm);
if (!prev) {
prev = mm->mmap;
@@ -1996,7 +1996,7 @@ void exit_mmap(struct mm_struct *mm)
vm_unacct_memory(nr_accounted);
BUG_ON(mm->map_count); /* This is just debugging */
clear_page_range(tlb, FIRST_USER_PGD_NR * PGDIR_SIZE,
- (TASK_SIZE + PGDIR_SIZE - 1) & PGDIR_MASK);
+ (MM_VM_SIZE(mm) + PGDIR_SIZE - 1) & PGDIR_MASK);
tlb_finish_mmu(tlb, 0, MM_VM_SIZE(mm));
--
dwmw2
next reply other threads:[~2005-01-25 22:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-25 22:26 David Woodhouse [this message]
2005-01-25 23:52 ` TASK_SIZE is variable David S. Miller
2005-01-26 6:36 ` Andi Kleen
2005-01-26 6:41 ` David S. Miller
2005-01-26 7:13 ` Andi Kleen
2005-01-26 7:24 ` Andrew Morton
2005-01-26 7:43 ` Andi Kleen
2005-01-26 8:01 ` Andrew Morton
2005-01-26 8:04 ` Andi Kleen
2005-01-28 2:58 ` Paul Mackerras
2005-01-28 3:11 ` Paul Mackerras
2005-01-28 3:17 ` Andrew Morton
2005-01-28 6:40 ` Andi Kleen
2005-01-29 11:23 ` Anton Blanchard
2005-01-28 8:46 ` Russell King
2005-01-28 6:39 ` Andi Kleen
2005-01-28 11:32 ` David Woodhouse
2005-01-26 7:54 ` David Woodhouse
2005-01-29 20:23 ` Andrew Morton
2005-01-29 23:28 ` Paul Mackerras
2005-01-30 11:01 ` Andi Kleen
2005-01-30 12:10 ` Paul Mackerras
2005-01-31 2:23 ` David S. Miller
2005-01-31 9:23 ` Andi Kleen
2005-01-31 19:29 ` David S. Miller
2005-01-31 19:38 ` Andi Kleen
2005-01-31 20:35 ` David S. Miller
2005-02-03 4:08 ` Andrew Morton
2005-02-03 6:28 ` David S. Miller
2005-02-03 7:19 ` Andi Kleen
2005-02-03 9:23 ` David Woodhouse
2005-01-31 2:33 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1106692012.6480.158.camel@localhost.localdomain \
--to=dwmw2@infradead.org \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.