[1/1] libipt_osf: fix iptables-1.3.0rc1 compilation.

[1/1] libipt_osf: fix iptables-1.3.0rc1 compilation.

[Evgeniy Polyakov]

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

Bug reported by Sami Farin <safari-kernel@safari.iki.fi>.

Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>

--- linux-2.6/include/linux/netfilter_ipv4/ipt_osf.h.orig 2005-02-07
19:11:08.237624320+0300
+++ linux-2.6/include/linux/netfilter_ipv4/ipt_osf.h    2005-02-07
19:11:43.854209776 +0300 @@ -33,9 +33,6 @@
 #define IPT_OSF_LOGLEVEL_ALL   0
 #define IPT_OSF_LOGLEVEL_FIRST 1

-#include <linux/list.h>
-#include <net/tcp.h>
-
 #ifndef __KERNEL__
 #include <netinet/ip.h>
 #include <netinet/tcp.h>
@@ -98,6 +95,10 @@

 #ifdef __KERNEL__

+#include <linux/list.h>
+#include <net/tcp.h>
+
+
 /* Defines for IANA option kinds */

 #define OSFOPT_EOL             0       /* End of options */

-- 
        Evgeniy Polyakov

Crash is better than data corruption -- Arthur Grabowski

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [1/1] libipt_osf: fix iptables-1.3.0rc1 compilation.

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

On Mon, Feb 07, 2005 at 08:29:53PM +0300, Evgeniy Polyakov wrote:
> Bug reported by Sami Farin <safari-kernel@safari.iki.fi>.
> 
> Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>

Erm, this is not a libipt_osf.c fix, but a ipt_osf.h fix.  And ipt_osf.h
is not part of the iptables-1.3.0rc1 package at all.

Please clarify, thanks.

-- 
- Harald Welte <laforge@netfilter.org>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [1/1] libipt_osf: fix iptables-1.3.0rc1 compilation.

[Evgeniy Polyakov]

On Mon, 7 Feb 2005 19:20:39 +0100
Harald Welte <laforge@netfilter.org> wrote:

> On Mon, Feb 07, 2005 at 08:29:53PM +0300, Evgeniy Polyakov wrote:
> > Bug reported by Sami Farin <safari-kernel@safari.iki.fi>.
> > 
> > Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
> 
> Erm, this is not a libipt_osf.c fix, but a ipt_osf.h fix.  And ipt_osf.h
> is not part of the iptables-1.3.0rc1 package at all.
> 
> Please clarify, thanks.

It was triggered by userspace libipt_osf compilation, 
which is part of iptables package, that is why I called it libipt_osf.c 
fix(userspace should not include kernel headers directly).

> -- 
> - Harald Welte <laforge@netfilter.org>             http://www.netfilter.org/
> ============================================================================
>   "Fragmentation is like classful addressing -- an interesting early
>    architectural error that shows how much experimentation was going
>    on while IP was being designed."                    -- Paul Vixie
> 


	Evgeniy Polyakov

Only failure makes us experts. -- Theo de Raadt