From: Bjorn Helgaas <bjorn-helgaas@comcast.net>
To: rmk+serial@arm.linux.org.uk, linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] [SERIAL] add TP560 data/fax/modem support
Date: Mon, 07 Feb 2005 12:39:42 -0700 [thread overview]
Message-ID: <1107805182.8074.35.camel@piglet> (raw)
Claim Topic TP560 data/fax/voice modem. This device reports as class 0x0780,
so we don't claim it by default:
00:0d.0 Class 0780: 151f:0000
Subsystem: 151f:0000
Interrupt: pin A routed to IRQ 11
Region 0: I/O ports at a400 [size=8]
00: 1f 15 00 00 01 00 00 02 00 00 80 07 00 00 00 00
10: 01 a4 00 00 00 00 00 00 00 00 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 1f 15 00 00
30: 00 00 00 00 00 00 00 00 00 00 00 00 0b 01 00 00
Some rc.serial scripts extract IRQ and I/O port information from
/proc/pci and stuff it into an unused port using setserial. That
doesn't work reliably anymore because pci_enable_device() is never
called, so the IRQ may not be enabled.
Thanks to Evan Clarke for reporting and helping debug this problem.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
===== drivers/serial/8250_pci.c 1.48 vs edited =====
--- 1.48/drivers/serial/8250_pci.c 2004-11-21 23:42:29 -07:00
+++ edited/drivers/serial/8250_pci.c 2005-02-07 12:00:32 -07:00
@@ -2212,6 +2212,13 @@
0, pbn_exar_XR17C158 },
/*
+ * Topic TP560 Data/Fax/Voice 56k modem (reported by Evan Clarke)
+ */
+ { PCI_VENDOR_ID_TOPIC, PCI_DEVICE_ID_TOPIC_TP560,
+ PCI_ANY_ID, PCI_ANY_ID, 0, 0,
+ pbn_b0_1_115200 },
+
+ /*
* These entries match devices with class COMMUNICATION_SERIAL,
* COMMUNICATION_MODEM or COMMUNICATION_MULTISERIAL
*/
===== include/linux/pci_ids.h 1.200 vs edited =====
--- 1.200/include/linux/pci_ids.h 2005-01-30 23:33:43 -07:00
+++ edited/include/linux/pci_ids.h 2005-02-07 11:56:14 -07:00
@@ -1972,6 +1972,9 @@
#define PCI_DEVICE_ID_BCM4401 0x4401
#define PCI_DEVICE_ID_BCM4401B0 0x4402
+#define PCI_VENDOR_ID_TOPIC 0x151f
+#define PCI_DEVICE_ID_TOPIC_TP560 0x0000
+
#define PCI_VENDOR_ID_ENE 0x1524
#define PCI_DEVICE_ID_ENE_1211 0x1211
#define PCI_DEVICE_ID_ENE_1225 0x1225
next reply other threads:[~2005-02-07 19:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-07 19:39 Bjorn Helgaas [this message]
2005-02-07 20:12 ` [PATCH] [SERIAL] add TP560 data/fax/modem support linux-os
2005-02-07 20:57 ` Bjorn Helgaas
2005-02-08 12:25 ` linux-os
2005-02-08 17:19 ` Bjorn Helgaas
2005-02-09 21:06 ` Bjorn Helgaas
2005-02-11 23:18 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1107805182.8074.35.camel@piglet \
--to=bjorn-helgaas@comcast.net \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.