From: Bjorn Helgaas <bjorn-helgaas@comcast.net>
To: linux-os@analogic.com
Cc: rmk+serial@arm.linux.org.uk, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [SERIAL] add TP560 data/fax/modem support
Date: Mon, 07 Feb 2005 13:57:35 -0700 [thread overview]
Message-ID: <1107809856.8074.50.camel@piglet> (raw)
In-Reply-To: <Pine.LNX.4.61.0502071508130.24378@chaos.analogic.com>
On Mon, 2005-02-07 at 15:12 -0500, linux-os wrote:
> I thought somebody promised to add a pci_route_irq(dev) or some
> such so that the device didn't have to be enabled before
> the IRQ was correct.
>
> I first reported this bad IRQ problem back in December of 2004.
> Has the new function been added?
That's a completely different problem. The point here is that
the serial driver currently doesn't do anything with the TP560
(no pci_enable_device(), no pci_route_irq(), no nothing). Then
when setserial comes along and force-feeds the driver with the
IO and IRQ info, there's nothing at that point that does anything
to enable the device or route its interrupt either.
I did raise the idea of adding a pci_route_irq() interface, but
to be honest, I was never convinced of its general usefulness.
I haven't heard of any driver in the tree that requires it,
so it's not clear that it would be accepted even if I (or you)
wrote it.
I think you mentioned a specific PCI interface chip that was
susceptible to the problem; is there a public reference that
would help explicate the situation?
next prev parent reply other threads:[~2005-02-07 20:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-07 19:39 [PATCH] [SERIAL] add TP560 data/fax/modem support Bjorn Helgaas
2005-02-07 20:12 ` linux-os
2005-02-07 20:57 ` Bjorn Helgaas [this message]
2005-02-08 12:25 ` linux-os
2005-02-08 17:19 ` Bjorn Helgaas
2005-02-09 21:06 ` Bjorn Helgaas
2005-02-11 23:18 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1107809856.8074.50.camel@piglet \
--to=bjorn-helgaas@comcast.net \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.