[PATCH] make ACPI_BLACKLIST_YEAR depend on ACPI

[PATCH] make ACPI_BLACKLIST_YEAR depend on ACPI

[Rolf Eike Beer]

Hi,

this oneliner fixes the situation that I can enter a year to blacklist
ACPI devices if ACPI is completely disabled.

Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>

--- linux-2.6.11-rc3/drivers/acpi/Kconfig	2005-02-07 21:12:45.000000000 +0100
+++ linux-2.6.11-rc3/drivers/acpi/Kconfig.fixed	2005-02-12 19:58:24.000000000 +0100
@@ -259,6 +259,7 @@
 
 config ACPI_BLACKLIST_YEAR
 	int "Disable ACPI for systems before Jan 1st this year"
+	depends on ACPI
 	default 0
 	help
 	  enter a 4-digit year, eg. 2001 to disable ACPI by default

Re: [PATCH] make ACPI_BLACKLIST_YEAR depend on ACPI

[Linus Torvalds]

On Mon, 14 Feb 2005, Rolf Eike Beer wrote:
> 
> this oneliner fixes the situation that I can enter a year to blacklist
> ACPI devices if ACPI is completely disabled.
> 
> Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>

Hmm.. Wouldn't it be even better to make it depend on ACPI_INTERPRETER? 
Afaik, the blacklist year is only ever used by the interperter, and the 
blacklist.c file isn't even built unless ACPI_INTERPRETER is on.

Len Brown added to check..

		Linus


> --- linux-2.6.11-rc3/drivers/acpi/Kconfig	2005-02-07 21:12:45.000000000 +0100
> +++ linux-2.6.11-rc3/drivers/acpi/Kconfig.fixed	2005-02-12 19:58:24.000000000 +0100
> @@ -259,6 +259,7 @@
>  
>  config ACPI_BLACKLIST_YEAR
>  	int "Disable ACPI for systems before Jan 1st this year"
> +	depends on ACPI
>  	default 0
>  	help
>  	  enter a 4-digit year, eg. 2001 to disable ACPI by default
> 

Re: [PATCH] make ACPI_BLACKLIST_YEAR depend on ACPI

[Len Brown]

Re: ACPI_BLACKLIST_YEAR depending on ACPI or ACPI_INTERPRETER -- either
are fine.

Note that I'm planning to delete the separate ACPI_INTERPRETER build
option and just use CONFIG_ACPI in the future.  We tested this in a
config clean-up in -mm a while back, and I should probably revive it for
early 2.6.12.  The reason is that there really isn't a valid concept of
ACPI without the interpreter -- it can't even be used for configuring
interrupts without the interpreter on hand.

thanks,
-Len

Re: [PATCH] make ACPI_BLACKLIST_YEAR depend on ACPI

[Roman Zippel]

Hi,

On Mon, 14 Feb 2005, Len Brown wrote:

> Re: ACPI_BLACKLIST_YEAR depending on ACPI or ACPI_INTERPRETER -- either
> are fine.

Note that a patch that fixes this and a little more is waiting in -mm and 
Sam's tree.

bye, Roman