ipt_ROUTE bug

ipt_ROUTE bug

[John Leach]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

Hi,

on compiling 2.6.11 with the ROUTE target patched in from patch-o-matic
snapshot 20050307, I get the following compile error:

  CC      net/ipv4/netfilter/ipt_ROUTE.o
net/ipv4/netfilter/ipt_ROUTE.c: In function `init':
net/ipv4/netfilter/ipt_ROUTE.c:452: error: structure has no member named
`initialized'
make[4]: *** [net/ipv4/netfilter/ipt_ROUTE.o] Error 1
make[3]: *** [net/ipv4/netfilter] Error 2
make[2]: *** [net/ipv4] Error 2
make[1]: *** [net] Error 2

the lines causing the problem are in the init() function:

        /* Initialize fake conntrack so that NAT will skip it */
        route_tee_track.nat.info.initialized |=
                (1 << IP_NAT_MANIP_SRC) | (1 << IP_NAT_MANIP_DST);

looking at ip_nat_init() in ip_nat_core.c my guess would be this should
be replaced with:

        route_tee_track.status |= IPS_NAT_DONE_MASK;

any comments?  I'm not at all familiar with the netfilter code, or even
kernel programming :S

John.


-- 
GPG: B89C D450 5B2C 74D8 58FB A360 9B06 B5C2 26F0 3047
WEB: http://johnleach.co.uk

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: ipt_ROUTE bug

[Cedric de Launois]

Le mercredi 09 mars 2005 à 12:11 +0000, John Leach a écrit :
> on compiling 2.6.11 with the ROUTE target patched in from patch-o-matic
> snapshot 20050307, I get the following compile error:
> 
>   CC      net/ipv4/netfilter/ipt_ROUTE.o
> net/ipv4/netfilter/ipt_ROUTE.c: In function `init':
> net/ipv4/netfilter/ipt_ROUTE.c:452: error: structure has no member named
> `initialized'
> make[4]: *** [net/ipv4/netfilter/ipt_ROUTE.o] Error 1
> make[3]: *** [net/ipv4/netfilter] Error 2
> make[2]: *** [net/ipv4] Error 2
> make[1]: *** [net] Error 2

This bug has already been fixed. See bugzilla #284.
The patch from Phil Oester has been committed to the
http://svn.netfilter.org/cgi-bin/viewcvs.cgi/branches/patch-o-matic-ng/linux-2.6.11 tree (Rev 3691)

Cedric

> the lines causing the problem are in the init() function:
> 
>         /* Initialize fake conntrack so that NAT will skip it */
>         route_tee_track.nat.info.initialized |=
>                 (1 << IP_NAT_MANIP_SRC) | (1 << IP_NAT_MANIP_DST);
> 
> looking at ip_nat_init() in ip_nat_core.c my guess would be this should
> be replaced with:
> 
>         route_tee_track.status |= IPS_NAT_DONE_MASK;
> 
> any comments?  I'm not at all familiar with the netfilter code, or even
> kernel programming :S
> 
> John.

Re: ipt_ROUTE bug

[John Leach]

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

*sigh*.  sorry about that.
Looks like I did good otherwise though :)

Thanks,

John.

On Wed, 2005-03-09 at 13:27 +0100, Cedric de Launois wrote:

> This bug has already been fixed. See bugzilla #284.
> The patch from Phil Oester has been committed to the
> http://svn.netfilter.org/cgi-bin/viewcvs.cgi/branches/patch-o-matic-ng/linux-2.6.11 tree (Rev 3691)
> 
> Cedric
> 

-- 
GPG: B89C D450 5B2C 74D8 58FB A360 9B06 B5C2 26F0 3047
WEB: http://johnleach.co.uk

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: ipt_ROUTE bug

[Cedric de Launois]

Le mercredi 09 mars 2005 à 12:43 +0000, John Leach a écrit :
> *sigh*.  sorry about that.

Thanks, rather.
I prefer being warned twice about the same bug than never ;)

> Looks like I did good otherwise though :)

Yup.

Cedric