tx_loadsz setserial bug?

tx_loadsz setserial bug?

[Craig Shelley]

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

Hi,
I think there may be a bug in 8250.c (linux 2.6.10) whereby tx_loadsz
(and possibly other info) is not updated when changing the uart type
using setserial eg

# setserial /dev/ttyS4
/dev/ttyS4, UART: 16550A, Port: 0xd000, IRQ: 5

# setserial /dev/ttyS4 uart 16550

# setserial /dev/ttyS4
/dev/ttyS4, UART: 16550, Port: 0xd000, IRQ: 5

Since tc_loadsz only gets set during autoconfig, it doesn't reflect the
port settings made using setserial

Replacing
	count = up->tx_loadsz;
With
	count = uart_config[up->port.type].tx_loadsz;

On line 1122 seemed to cure my problem as a temporary bodge fix, but it
looks like a more significant alteration is required in order to fix it
properly.



-- 
Craig Shelley
EMail: craig@microtron.org.uk
Jabber: shell@jabber.earth.li

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]