From: Dave Hansen <haveblue@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Whitcroft <apw@shadowen.org>
Subject: Re: [RFC][PATCH 5/6] sparsemem: more separation between NUMA and DISCONTIG
Date: Fri, 18 Mar 2005 15:16:17 -0800 [thread overview]
Message-ID: <1111187778.9648.49.camel@localhost> (raw)
In-Reply-To: <20050318150826.4ca3ad14.akpm@osdl.org>
On Fri, 2005-03-18 at 15:08 -0800, Andrew Morton wrote:
> Dave Hansen <haveblue@us.ibm.com> wrote:
> >
> > There is some confusion with the SPARSEMEM patch between what
> > is needed for DISCONTIG vs. NUMA. For instance, the NODE_DATA()
> > macro needs to be switched on NUMA, but not on FLATMEM.
> >
> > This patch is required if the previous patch is applied.
>
> This patch breaks !CONFIG_NUMA ppc64:
>
> include/linux/mmzone.h:387:1: warning: "NODE_DATA" redefined
> include/asm/mmzone.h:55:1: warning: this is the location of the previous definition
>
> I'll hack around it for now.
I'll make sure to have it fixed properly in my copy.
Could I have a copy of your .config? I'm keeping a growing collection.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Whitcroft <apw@shadowen.org>
Subject: Re: [RFC][PATCH 5/6] sparsemem: more separation between NUMA and DISCONTIG
Date: Fri, 18 Mar 2005 15:16:17 -0800 [thread overview]
Message-ID: <1111187778.9648.49.camel@localhost> (raw)
In-Reply-To: <20050318150826.4ca3ad14.akpm@osdl.org>
On Fri, 2005-03-18 at 15:08 -0800, Andrew Morton wrote:
> Dave Hansen <haveblue@us.ibm.com> wrote:
> >
> > There is some confusion with the SPARSEMEM patch between what
> > is needed for DISCONTIG vs. NUMA. For instance, the NODE_DATA()
> > macro needs to be switched on NUMA, but not on FLATMEM.
> >
> > This patch is required if the previous patch is applied.
>
> This patch breaks !CONFIG_NUMA ppc64:
>
> include/linux/mmzone.h:387:1: warning: "NODE_DATA" redefined
> include/asm/mmzone.h:55:1: warning: this is the location of the previous definition
>
> I'll hack around it for now.
I'll make sure to have it fixed properly in my copy.
Could I have a copy of your .config? I'm keeping a growing collection.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-03-18 23:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-17 0:28 [RFC][PATCH 5/6] sparsemem: more separation between NUMA and DISCONTIG Dave Hansen
2005-03-17 0:28 ` Dave Hansen
2005-03-18 23:08 ` Andrew Morton
2005-03-18 23:08 ` Andrew Morton
2005-03-18 23:16 ` Dave Hansen [this message]
2005-03-18 23:16 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1111187778.9648.49.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.