All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	"David S. Miller" <davem@davemloft.net>,
	Network Development Mailing List <netdev@oss.sgi.com>
Subject: Re: [NET] make all protos partially use sk_prot
Date: Sat, 26 Mar 2005 14:36:03 +0100	[thread overview]
Message-ID: <1111844163.9195.191.camel@pegasus> (raw)
In-Reply-To: <39e6f6c7050326051571ef8272@mail.gmail.com>

Hi Arnaldo,

> Ah, apart from these style changes, do you think the real changes in this patch
> are worth?

actually I am the wrong person to judge on this. However if socket users
don't have to care about owner and slab anymore (or at least less), I
think it is a good thing to do.

Btw all the ".slab = NULL," stuff in the proto declarations is not
needed and we normally omit values that are 0 or NULL.

And some of the proto__seq_* functions are not static. What is the
reason to have them public?

Regards

Marcel

  reply	other threads:[~2005-03-26 13:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-26  0:39 [NET] make all protos partially use sk_prot Arnaldo Carvalho de Melo
2005-03-26 13:09 ` Marcel Holtmann
2005-03-26 13:13   ` Arnaldo Carvalho de Melo
2005-03-26 13:15     ` Arnaldo Carvalho de Melo
2005-03-26 13:36       ` Marcel Holtmann [this message]
2005-03-26 13:42         ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1111844163.9195.191.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=acme@conectiva.com.br \
    --cc=acme@ghostprotocols.net \
    --cc=davem@davemloft.net \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.