Re: [NET] make all protos partially use sk_prot

[Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>]

On Sat, 26 Mar 2005 14:36:03 +0100, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Arnaldo,
> 
> > Ah, apart from these style changes, do you think the real changes in this patch
> > are worth?
> 
> actually I am the wrong person to judge on this. However if socket users
> don't have to care about owner and slab anymore (or at least less), I
> think it is a good thing to do.

OK.

> Btw all the ".slab = NULL," stuff in the proto declarations is not
> needed and we normally omit values that are 0 or NULL.

I used to be a top nitpicker for this kind of stuff, and avoid it a
lot, but used
this time only to clearly state that this protocol doesn't use a slab cache,
anyway, I'll remove those as well, as we can see which protocols are not
using a slab thru /proc/net/protocols, introduced in this changeset.

> And some of the proto__seq_* functions are not static. What is the
> reason to have them public?

My mistake, thanks for pointing this out, new patch in the works.

- Arnaldo