From: James Bottomley <James.Bottomley@SteelEye.com>
To: Mark Haverkamp <markh@osdl.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Mark Salyzyn <mark_salyzyn@adaptec.com>
Subject: Re: [PATCH] 2.6 aacraid: endian cleanup
Date: Mon, 28 Mar 2005 15:58:48 -0600 [thread overview]
Message-ID: <1112047128.5531.78.camel@mulgrave> (raw)
In-Reply-To: <1111430484.9918.9.camel@markh1.pdx.osdl.net>
On Mon, 2005-03-21 at 10:41 -0800, Mark Haverkamp wrote:
> + Adaptec 2130S
Why are we getting updated card support in an endian cleanup patch?
> +/*
> + * Some configurations of BE Linux have writel and readl automatically perform
> + * byte swapping, and some configurations (embedded) do not. Typically
> + * AAC_IO_USES_CPU_ORDER needs to be defined since most BE ports are working
> + * with drivers that have not been coded to support BE.
> + */
> +#define AAC_IO_USES_CPU_ORDER 1
> +#ifdef AAC_IO_USES_CPU_ORDER
> +# define aac_io_le32_to_cpu
> +# define aac_io_cpu_to_le16
> +# define aac_io_cpu_to_le32
> +#else
> +# define aac_io_le32_to_cpu le32_to_cpu
> +# define aac_io_cpu_to_le16 cpu_to_le16
> +# define aac_io_cpu_to_le32 cpu_to_le32
> +#endif
What exactly is this for? I know of no platforms that implement readl
and friends incorrectly, so all of this should be unnecessary.
James
next prev parent reply other threads:[~2005-03-28 21:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-21 18:41 [PATCH] 2.6 aacraid: endian cleanup Mark Haverkamp
2005-03-28 21:58 ` James Bottomley [this message]
2005-03-28 22:04 ` Mark Haverkamp
2005-03-28 22:17 ` James Bottomley
2005-03-28 21:59 ` Christoph Hellwig
2005-03-28 22:05 ` Mark Haverkamp
2005-03-28 23:28 ` Mark Haverkamp
2005-03-28 23:36 ` Randy.Dunlap
2005-03-28 23:38 ` Mark Haverkamp
2005-03-29 16:49 ` Mark Haverkamp
2005-03-29 16:51 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2005-03-28 23:02 Salyzyn, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1112047128.5531.78.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
--cc=markh@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.