From: Christoph Hellwig <hch@infradead.org>
To: Mark Haverkamp <markh@osdl.org>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Mark Salyzyn <mark_salyzyn@adaptec.com>
Subject: Re: [PATCH] 2.6 aacraid: endian cleanup
Date: Tue, 29 Mar 2005 17:51:28 +0100 [thread overview]
Message-ID: <20050329165128.GA30917@infradead.org> (raw)
In-Reply-To: <1112114974.16948.13.camel@markh1.pdx.osdl.net>
On Tue, Mar 29, 2005 at 08:49:33AM -0800, Mark Haverkamp wrote:
> I ran sparse on the driver and without the -Wbitwise, it only has 7
> warnings such as:
>
> CHECK drivers/scsi/aacraid/linit.c
> drivers/scsi/aacraid/linit.c:218:12: warning: symbol 'aac_info' was not declared. Should it be static?
>
> With -Wbitwise there are about 200 warnings of this sort:
> drivers/scsi/aacraid/aachba.c:180:18: warning: incorrect type in assignment (different base types)
> drivers/scsi/aacraid/aachba.c:180:18: expected unsigned int [unsigned] [usertype] command
> drivers/scsi/aacraid/aachba.c:180:18: got restricted unsigned int [usertype] [force] <noident>
>
> What is your preference, I could clean up the existing patch and re-
> submit and then address the sparse warnings with a follow-up patch. Or
> try to fix everything in one patch.
I think we can postpone the sparse fixes to a followon patch.
next prev parent reply other threads:[~2005-03-29 16:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-21 18:41 [PATCH] 2.6 aacraid: endian cleanup Mark Haverkamp
2005-03-28 21:58 ` James Bottomley
2005-03-28 22:04 ` Mark Haverkamp
2005-03-28 22:17 ` James Bottomley
2005-03-28 21:59 ` Christoph Hellwig
2005-03-28 22:05 ` Mark Haverkamp
2005-03-28 23:28 ` Mark Haverkamp
2005-03-28 23:36 ` Randy.Dunlap
2005-03-28 23:38 ` Mark Haverkamp
2005-03-29 16:49 ` Mark Haverkamp
2005-03-29 16:51 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-28 23:02 Salyzyn, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050329165128.GA30917@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
--cc=markh@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.