All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>, Len Brown <len.brown@intel.com>,
	"Luck, Tony" <tony.luck@intel.com>, Greg KH <greg@kroah.com>,
	acpi-devel@lists.sourceforge.net, linux-ia64@vger.kernel.org,
	pcihpd-discuss@lists.sourceforge.net
Subject: Re: [ACPI] [RFC/PATCH 3/3] ACPI based I/O APIC hot-plug
Date: Fri, 22 Apr 2005 08:58:01 -0600	[thread overview]
Message-ID: <1114181881.4902.4.camel@eeyore> (raw)
In-Reply-To: <42689BEB.90401@jp.fujitsu.com>

On Fri, 2005-04-22 at 15:38 +0900, Kenji Kaneshige wrote:
> Bjorn Helgaas wrote:
> > 
> >>+		if ((dev->class >> 8) != PCI_CLASS_SYSTEM_PIC)
> >>+			continue;
> >>+		if ((dev->class & 0xff) == 0x10 || (dev->class & 0xff) == 0x20)
> > 
> > 
> > What are 0x10 and 0x20?  Looks like they should be #defines in
> > include/linux/pci_ids.h.
> 
> 0x10 and 0x20 are programing interfaces for I/O APIC and I/O xAPIC
> respectively. #define for these values looks good. But I don't know
> if I can put new #defines into pci_ids.h and how to name them because
> I could not find the header file (including pci_ids.h) that #defines
> the values for programming interfaces. So I want to add the comments
> to explain these values (0x10, 0x20) instead of adding new #defines into
> pci_ids.h for now.

I think your patch should just add the values to pci_ids.h.  If
somebody doesn't like that, he or she will complain and you can fall
back to just using 0x10 and 0x20.  But I suspect it will be fine.


WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>, Len Brown <len.brown@intel.com>,
	"Luck, Tony" <tony.luck@intel.com>, Greg KH <greg@kroah.com>,
	acpi-devel@lists.sourceforge.net, linux-ia64@vger.kernel.org,
	pcihpd-discuss@lists.sourceforge.net
Subject: Re: [ACPI] [RFC/PATCH 3/3] ACPI based I/O APIC hot-plug
Date: Fri, 22 Apr 2005 14:58:01 +0000	[thread overview]
Message-ID: <1114181881.4902.4.camel@eeyore> (raw)
In-Reply-To: <42689BEB.90401@jp.fujitsu.com>

On Fri, 2005-04-22 at 15:38 +0900, Kenji Kaneshige wrote:
> Bjorn Helgaas wrote:
> > 
> >>+		if ((dev->class >> 8) != PCI_CLASS_SYSTEM_PIC)
> >>+			continue;
> >>+		if ((dev->class & 0xff) = 0x10 || (dev->class & 0xff) = 0x20)
> > 
> > 
> > What are 0x10 and 0x20?  Looks like they should be #defines in
> > include/linux/pci_ids.h.
> 
> 0x10 and 0x20 are programing interfaces for I/O APIC and I/O xAPIC
> respectively. #define for these values looks good. But I don't know
> if I can put new #defines into pci_ids.h and how to name them because
> I could not find the header file (including pci_ids.h) that #defines
> the values for programming interfaces. So I want to add the comments
> to explain these values (0x10, 0x20) instead of adding new #defines into
> pci_ids.h for now.

I think your patch should just add the values to pci_ids.h.  If
somebody doesn't like that, he or she will complain and you can fall
back to just using 0x10 and 0x20.  But I suspect it will be fine.


  reply	other threads:[~2005-04-22 14:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-21 13:39 [RFC/PATCH 3/3] ACPI based I/O APIC hot-plug Kenji Kaneshige
2005-04-21 13:39 ` Kenji Kaneshige
2005-04-21 17:22 ` [ACPI] " Bjorn Helgaas
2005-04-21 17:22   ` Bjorn Helgaas
2005-04-22  6:38   ` Kenji Kaneshige
2005-04-22  6:38     ` Kenji Kaneshige
2005-04-22 14:58     ` Bjorn Helgaas [this message]
2005-04-22 14:58       ` Bjorn Helgaas
2005-04-22 15:15       ` Greg KH
2005-04-22 15:15         ` [ACPI] " Greg KH
2005-04-25  9:16       ` Kenji Kaneshige
2005-04-25  9:16         ` Kenji Kaneshige

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1114181881.4902.4.camel@eeyore \
    --to=bjorn.helgaas@hp.com \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=len.brown@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=pcihpd-discuss@lists.sourceforge.net \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.