A few more gcc4isms

A few more gcc4isms

[Paul Larson]

[-- Attachment #1.1: Type: text/plain, Size: 866 bytes --]

Here's a couple more gcc4 cleanups.
Signed-off-by: Paul Larson <pl@us.ibm.com>

--- xen-unstable/xen/common/grant_table.c2005-04-21 22:14:31.000000000
-0500
+++ xen-unstable-fix/xen/common/grant_table.c2005-04-22
14:54:34.000000000 -0500@@ -437,7 +437,7 @@ gnttab_map_grant_ref(
     gnttab_map_grant_ref_t *uop, unsigned int count)
 {
     int i, flush = 0;
-    unsigned long va;
+    unsigned long va=0;

     for ( i = 0; i < count; i++ )
         if ( __gnttab_map_grant_ref(&uop[i], &va) == 0 )
@@ -633,7 +633,7 @@ gnttab_unmap_grant_ref(
     gnttab_unmap_grant_ref_t *uop, unsigned int count)
 {
     int i, flush = 0;
-    unsigned long va;
+    unsigned long va=0;

     for ( i = 0; i < count; i++ )
         if ( __gnttab_unmap_grant_ref(&uop[i], &va) == 0 )
-- 
Thanks,
Paul Larson
pl@us.ibm.com
IBM Linux Technology Center

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: A few more gcc4isms

[Adam Heath]

On Fri, 22 Apr 2005, Paul Larson wrote:

> Here's a couple more gcc4 cleanups.
> Signed-off-by: Paul Larson <pl@us.ibm.com>
>
> --- xen-unstable/xen/common/grant_table.c2005-04-21 22:14:31.000000000
> -0500
> +++ xen-unstable-fix/xen/common/grant_table.c2005-04-22
> 14:54:34.000000000 -0500@@ -437,7 +437,7 @@ gnttab_map_grant_ref(
>      gnttab_map_grant_ref_t *uop, unsigned int count)
>  {
>      int i, flush = 0;
> -    unsigned long va;
> +    unsigned long va=0;
>
>      for ( i = 0; i < count; i++ )
>          if ( __gnttab_map_grant_ref(&uop[i], &va) == 0 )
> @@ -633,7 +633,7 @@ gnttab_unmap_grant_ref(
>      gnttab_unmap_grant_ref_t *uop, unsigned int count)
>  {
>      int i, flush = 0;
> -    unsigned long va;
> +    unsigned long va=0;
>
>      for ( i = 0; i < count; i++ )
>          if ( __gnttab_unmap_grant_ref(&uop[i], &va) == 0 )
> --

Actually, there's a window here for gcc to grow an extension.

An attribute on the second arg of gnttab_unmap_grant_ref, that says it doesn't
read it, but instead writes a value to it, would allow for these unitialized
warnings to not appear.