From: Jeremy Rosen <jeremy.rosen@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] Allow a single DHCP configuration via the system configuration submenu
Date: Fri, 16 Jan 2015 16:30:11 +0100 (CET) [thread overview]
Message-ID: <1114301633.30415740.1421422210368.JavaMail.root@openwide.fr> (raw)
In-Reply-To: <20150116161921.5fa45e55@free-electrons.com>
> Dear J?r?my Rosen,
>
> On Fri, 16 Jan 2015 14:08:39 +0100, J?r?my Rosen wrote:
>
> > +config BR2_SIMPLE_DHCP
> > + string "Name of the physical network interface to run DHCP on"
> > + default ""
> > + depends on !BR2_PACKAGE_SYSTEMD_NETWORKD && (BR2_PACKAGE_BUSYBOX
> > || BR2_PACKAGE_IFUPDOWN)
> > + help
> > + The name of the network interface to configure automatically.
> > + A DHCP request will automatically happen on startup on the
> > selected
> > + interface.
> > +
> > + If left empty, no automatic DHCP requests will take place.
> > +
> > + For more complicated network setups use an overlay to overwrite
> > + /etc/network/interfaces or add a networkd configuration file.
> > +
> > +comment "automatic network configuration via DHCP is not
> > compatible with networkd"
> > + depends on BR2_PACKAGE_SYSTEMD_NETWORKD
> > +
> > +comment "automatic network configuration via DHCP needs ifupdown
> > or busybox"
> > + depends on !(BR2_PACKAGE_BUSYBOX || BR2_PACKAGE_IFUPDOWN)
>
> I'm still not really happy with this. It's
> really /etc/network/interfaces as a whole that doesn't make sense in
> a
> context where you don't have Busybox ifupdown, or the full blown
> ifupdown, no? Not just the DHCP part of it.
>
i'm not sure how you want me to correct that...
* not generate network/interfaces at all if ifupdown is not available
* correct the comment sections "generation of /etc/network/interfaces needs ifupdown"
(but that does not reflect what the option is when it is available)
* something else
please tell me and i'll send a new patch
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
>
next prev parent reply other threads:[~2015-01-16 15:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 13:08 [Buildroot] [PATCH v4] Allow a single DHCP configuration via the system configuration submenu Jérémy Rosen
2015-01-16 15:19 ` Thomas Petazzoni
2015-01-16 15:30 ` Jeremy Rosen [this message]
2015-02-02 16:36 ` Peter Korsgaard
2015-02-02 16:38 ` Jeremy Rosen
2015-02-14 16:18 ` Steve Kenton
2015-02-15 20:12 ` Peter Korsgaard
2015-02-15 22:04 ` Steve Kenton
2015-02-15 22:11 ` Peter Korsgaard
2015-02-16 3:06 ` Steve Kenton
2015-02-16 8:46 ` Jeremy Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114301633.30415740.1421422210368.JavaMail.root@openwide.fr \
--to=jeremy.rosen@openwide.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.