All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Rosen <jeremy.rosen@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] Allow a single DHCP configuration via the system configuration submenu
Date: Mon, 2 Feb 2015 17:38:25 +0100 (CET)	[thread overview]
Message-ID: <98184085.31058823.1422895105455.JavaMail.root@openwide.fr> (raw)
In-Reply-To: <878uggi834.fsf@dell.be.48ers.dk>


> 
> Sorry for the slow response. We have discussed this during the dev
> days
> and agreed to include it. Committed with some changes, see below.
> 
> Thanks!


Thanks a lot, really appreciated :)

> 
> > +config BR2_SIMPLE_DHCP
> 
> We're not completely consist with this, but the new system options
> are
> called BR2_SYSTEM_*, so I've renamed to the option.
> 
> > +	string "Name of the physical network interface to run DHCP on"
> 
> This is quite long, so I reworded it to:
> 
> "Network interface to configure through DHCP"
> 
> > +	default ""
>  > +	depends on !BR2_PACKAGE_SYSTEMD_NETWORKD && (BR2_PACKAGE_BUSYBOX
>  > || BR2_PACKAGE_IFUPDOWN)
>  > +	help
>  > +	  The name of the network interface to configure automatically.
>  > +	  A DHCP request will automatically happen on startup on the
>  > selected
>  > +	  interface.
> 
> And here I reworded it a bit and mentioned an example (eth0).
> 
>  
>  > +define SET_NETWORK_LOCALHOST
>  > +        echo "# interface file auto-generated by buildroot" >
>  >  $(TARGET_DIR)/etc/network/interfaces
>  > +        echo                                                >>
>  > $(TARGET_DIR)/etc/network/interfaces
>  > +        echo "auto lo"                                      >>
>  > $(TARGET_DIR)/etc/network/interfaces
>  > +        echo "iface lo inet loopback"                       >>
>  > $(TARGET_DIR)/etc/network/interfaces
>  > +        echo                                                >>
>  > $(TARGET_DIR)/etc/network/interfaces
>  > +endef
> 
> Elsewhere in BR we use syntax like:
> 
> ( \
>   echo foo ; \
>   echo bar ; \
> ) > file
> 
> Which is a bit less verbose, so I've changed it to that.
> 
> --
> Bye, Peter Korsgaard
> 

  reply	other threads:[~2015-02-02 16:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 13:08 [Buildroot] [PATCH v4] Allow a single DHCP configuration via the system configuration submenu Jérémy Rosen
2015-01-16 15:19 ` Thomas Petazzoni
2015-01-16 15:30   ` Jeremy Rosen
2015-02-02 16:36 ` Peter Korsgaard
2015-02-02 16:38   ` Jeremy Rosen [this message]
2015-02-14 16:18     ` Steve Kenton
2015-02-15 20:12       ` Peter Korsgaard
2015-02-15 22:04         ` Steve Kenton
2015-02-15 22:11           ` Peter Korsgaard
2015-02-16  3:06             ` Steve Kenton
2015-02-16  8:46         ` Jeremy Rosen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98184085.31058823.1422895105455.JavaMail.root@openwide.fr \
    --to=jeremy.rosen@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.