Re: [Bluez-devel] Re: a2play code that is working

[Marcel Holtmann <marcel@holtmann.org>]

Hi Mayank,

> > There is sometimes a delay before cvs gets updated
> > by sourceforge. I had 
> > made those changes to sbc.h
> 
> Are you sure it will be ok if we change the sbc.h and
> sbc.c files ?
> Because then the other applications making use of the
> sbc encoder will also have to change accordingly...??

there is no official SBC library release yet and so there is no problem
at all. For the pcm_a2dp plugin I copied the SBC code.

However I don't agree with these changes and you should never do a
library change together with the application change. Always make it two
different change sets. This is easier for tracking and I actually missed
that you changed the SBC library.

Now commenting on the change itself. The "struct sbc_frame_header"
should not placed inside the sbc.h header file. This is the API
interface and we don't need a definition of the SBC file format there.
If you wanna modify the additional SBC parameters add them to sbc_struct
and set them there. Please fix this.

Also a library should not use printf() at all. Remove them and improve
the return values to match -ENOMEM etc.

Regards

Marcel




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel