Re: [Bluez-devel] Re: a2play code that is working

[Marcel Holtmann <marcel@holtmann.org>]

Hi Brad,

> How about if I move the declaration for struct sbc_frame into sbc.h and 
> change that last argument to sbc_encode to be an sbc_frame *
> 
> We wouldn't expose the data in the private struct, but just reuse the 
> struct for communicating sbc info back to the caller...

this is a bad idea, because then we can never change the internals of
the decoder/encoder. One of the goals should be to get a SBC codec that
uses only integer operation.

The sbc_struct already contains "rate" and "channels" and we should
simply add the rest of them. I was do lazy to do in the first place and
actually because I had no use for them.

Regards

Marcel




-------------------------------------------------------
SF.Net email is sponsored by: Tell us your software development plans!
Take this survey and enter to win a one-year sub to SourceForge.net
Plus IDC's 2005 look-ahead and a copy of this survey
Click here to start!  http://www.idcswdc.com/cgi-bin/survey?id=105hix
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel