[KJ][PATCH] removal of useless call to 'keepalive_time_when'

[KJ][PATCH] removal of useless call to 'keepalive_time_when'

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

I have found a call to keepalive_time_when in net/ipv4/tcp_timer.c that
looks like useless. The returned value is overwritten few lines of code
below, without beeing used.

cheers,

Paolo



 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Scopri il benessere che solo l���aloe vera regala al tuo corpo: cura la tua pelle
* Con la vasta gamma di prodotti che ti offre Erboristeria.com
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=2380&d=28-4

[-- Attachment #2: removed_unused_keepalive_time.patch --]
[-- Type: text/x-patch, Size: 443 bytes --]

--- linux-2.6.12-rc3/net/ipv4/tcp_timer.c.orig	2005-04-28 09:50:15.352625672 +0200
+++ linux-2.6.12-rc3/net/ipv4/tcp_timer.c	2005-04-28 09:52:01.481491632 +0200
@@ -606,8 +606,6 @@ static void tcp_keepalive_timer (unsigne
 	if (!sock_flag(sk, SOCK_KEEPOPEN) || sk->sk_state == TCP_CLOSE)
 		goto out;
 
-	elapsed = keepalive_time_when(tp);
-
 	/* It is alive without keepalive 8) */
 	if (tp->packets_out || sk->sk_send_head)
 		goto resched;

[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ][PATCH] removal of useless call to 'keepalive_time_when'

[Kristen Accardi]

[-- Attachment #1: Type: text/plain, Size: 903 bytes --]

On Thu, 2005-04-28 at 10:06 +0200, Paolo Abeni wrote:
> I have found a call to keepalive_time_when in net/ipv4/tcp_timer.c that
> looks like useless. The returned value is overwritten few lines of code
> below, without beeing used.

	Actually, if you look, the value that was returned to "elapsed" is
actually used if you take the goto to resched.  So, it's not useless.

kristen


> 
> cheers,
> 
> Paolo
> 
> 
> 
>  
> 
>  --
>  Email.it, the professional e-mail, gratis per te: http://www.email.it/f
>  
>  Sponsor:
>  Scopri il benessere che solo laloe vera regala al tuo corpo: cura la tua pelle
> * Con la vasta gamma di prodotti che ti offre Erboristeria.com
>  Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=2380&d=28-4
> _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors