From: Mike Tran <mhtran@us.ibm.com>
To: neilb@cse.unsw.edu.au, axboe@suse.de, linux-raid@vger.kernel.org
Subject: [PATCH] raid1: set bi_idx after bio cloning
Date: Fri, 13 May 2005 16:39:02 -0500 [thread overview]
Message-ID: <1116020307.6557.34.camel@langvan2.homenetwork> (raw)
Hi Neil et al,
The scenario: Having LVM (striped) volumes on top of 2 raid1 devices
The problem: Corruption in building the scatter gather list for
device driver (see /drivers/block/blk_rq_map_sg() function)
In DM code, a bio sometimes can be split into several
clones and the clones' bi_idx is set accordingly by DM. MD raid1 also
clones bio but does not adjust bi_idx. The problem can be fixed in
either __bio_clone() or the caller of bio_clone(). I chose to fix
raid1.
--- linux-2.6.12-rc4-orig/drivers/md/raid1.c 2005-05-10 13:35:06.000000000-0500
+++ linux-2.6.12-rc4-patch/drivers/md/raid1.c 2005-05-13 15:41:43.000000000-0500
@@ -577,6 +577,7 @@
r1_bio->bios[rdisk] = read_bio;
+ read_bio->bi_idx = bio->bi_idx;
read_bio->bi_sector = r1_bio->sector + mirror->rdev->data_offset;
read_bio->bi_bdev = mirror->rdev->bdev;
read_bio->bi_end_io = raid1_end_read_request;
--
Regards,
Mike T.
next reply other threads:[~2005-05-13 21:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-13 21:39 Mike Tran [this message]
2005-05-13 23:08 ` [PATCH] raid1: set bi_idx after bio cloning Neil Brown
2005-05-16 15:25 ` [PATCH] bio: " Mike Tran
2005-05-16 22:19 ` problems with 3ware 8506-8 post-disk failure Harry Mangalam
2005-05-23 7:31 ` [PATCH] bio: set bi_idx after bio cloning Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1116020307.6557.34.camel@langvan2.homenetwork \
--to=mhtran@us.ibm.com \
--cc=axboe@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.