From: Jens Axboe <axboe@suse.de>
To: Mike Tran <mhtran@us.ibm.com>
Cc: Neil Brown <neilb@cse.unsw.edu.au>, linux-raid@vger.kernel.org
Subject: Re: [PATCH] bio: set bi_idx after bio cloning
Date: Mon, 23 May 2005 09:31:32 +0200 [thread overview]
Message-ID: <20050523073131.GD9855@suse.de> (raw)
In-Reply-To: <1116257122.15450.6.camel@langvan2.homenetwork>
On Mon, May 16 2005, Mike Tran wrote:
>
> Hi Jens,
>
> Unless you have specific reason for not doing in __bio_clone(), I agree
> with Neil's suggestion. Please consider the following patch:
>
> --- linux-2.6.12-rc4-orig/fs/bio.c 2005-05-16 10:13:27.000000000 -0500
> +++ linux-2.6.12-rc4-patch/fs/bio.c 2005-05-16 10:15:06.000000000 -0500
> @@ -255,10 +255,7 @@
> bio->bi_flags |= 1 << BIO_CLONED;
> bio->bi_rw = bio_src->bi_rw;
>
> - /*
> - * notes -- maybe just leave bi_idx alone. assume identical mapping
> - * for the clone
> - */
> + bio->bi_idx = bio_src->bi_idx;
> bio->bi_vcnt = bio_src->bi_vcnt;
> bio->bi_size = bio_src->bi_size;
> bio_phys_segments(q, bio);
That patch is fine with me, I'll add it. Thanks.
--
Jens Axboe
prev parent reply other threads:[~2005-05-23 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-13 21:39 [PATCH] raid1: set bi_idx after bio cloning Mike Tran
2005-05-13 23:08 ` Neil Brown
2005-05-16 15:25 ` [PATCH] bio: " Mike Tran
2005-05-16 22:19 ` problems with 3ware 8506-8 post-disk failure Harry Mangalam
2005-05-23 7:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050523073131.GD9855@suse.de \
--to=axboe@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=mhtran@us.ibm.com \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.