All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: christoph <christoph@scalex86.org>
Cc: linux-mm <linux-mm@kvack.org>,
	shai@scalex86.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Factor in buddy allocator alignment requirements in node memory alignment
Date: Mon, 16 May 2005 13:47:19 -0700	[thread overview]
Message-ID: <1116276439.1005.110.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.62.0505161240240.13692@ScMPusgw>

On Mon, 2005-05-16 at 12:43 -0700, christoph wrote:
> On Mon, 16 May 2005, Dave Hansen wrote:
> > On Mon, 2005-05-16 at 12:05 -0700, christoph wrote:
> > > Memory for nodes on i386 is currently aligned on 2 MB boundaries.
> > > However, the buddy allocator needs pages to be aligned on
> > > PAGE_SIZE << MAX_ORDER which is 8MB if MAX_ORDER = 11.
> > 
> > Why do you need this?  Are you planning on allowing NUMA KVA remap pages
> > to be handed over to the buddy allocator?  That would be a major
> > departure from what we do now, and I'd be very interested in seeing how
> > that is implemented before a infrastructure for it goes in.
> 
> Because the buddy allocator is complaining about wrongly allocated zones!

Just because it complains doesn't mean that anything is actually
wrong :)

Do you know which pieces of code actually break if the alignment doesn't
meet what that warning says?

-- Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: christoph <christoph@scalex86.org>
Cc: linux-mm <linux-mm@kvack.org>,
	shai@scalex86.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Factor in buddy allocator alignment requirements in node memory alignment
Date: Mon, 16 May 2005 13:47:19 -0700	[thread overview]
Message-ID: <1116276439.1005.110.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.62.0505161240240.13692@ScMPusgw>

On Mon, 2005-05-16 at 12:43 -0700, christoph wrote:
> On Mon, 16 May 2005, Dave Hansen wrote:
> > On Mon, 2005-05-16 at 12:05 -0700, christoph wrote:
> > > Memory for nodes on i386 is currently aligned on 2 MB boundaries.
> > > However, the buddy allocator needs pages to be aligned on
> > > PAGE_SIZE << MAX_ORDER which is 8MB if MAX_ORDER = 11.
> > 
> > Why do you need this?  Are you planning on allowing NUMA KVA remap pages
> > to be handed over to the buddy allocator?  That would be a major
> > departure from what we do now, and I'd be very interested in seeing how
> > that is implemented before a infrastructure for it goes in.
> 
> Because the buddy allocator is complaining about wrongly allocated zones!

Just because it complains doesn't mean that anything is actually
wrong :)

Do you know which pieces of code actually break if the alignment doesn't
meet what that warning says?

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  reply	other threads:[~2005-05-16 20:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-16 19:05 [PATCH] Factor in buddy allocator alignment requirements in node memory alignment christoph
2005-05-16 19:05 ` christoph
2005-05-16 20:14 ` Dave Hansen
2005-05-16 20:14   ` Dave Hansen
2005-05-16 19:43   ` christoph
2005-05-16 19:43     ` christoph
2005-05-16 20:47     ` Dave Hansen [this message]
2005-05-16 20:47       ` Dave Hansen
2005-05-16 19:55       ` christoph
2005-05-16 19:55         ` christoph
2005-05-16 20:56         ` Dave Hansen
2005-05-16 20:56           ` Dave Hansen
2005-05-16 20:12           ` christoph
2005-05-16 20:12             ` christoph
2005-05-16 21:06         ` Martin J. Bligh
2005-05-16 21:06           ` Martin J. Bligh
2005-05-17 13:12       ` Andrea Arcangeli
2005-05-17 13:12         ` Andrea Arcangeli
2005-05-17 14:16         ` Andy Whitcroft
2005-05-17 14:16           ` Andy Whitcroft
2005-05-16 20:51     ` Martin J. Bligh
2005-05-16 20:51       ` Martin J. Bligh
2005-05-17 12:25     ` Andy Whitcroft
2005-05-17 12:25       ` Andy Whitcroft
2005-05-17 17:19       ` christoph
2005-05-17 17:19         ` christoph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1116276439.1005.110.camel@localhost \
    --to=haveblue@us.ibm.com \
    --cc=christoph@scalex86.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shai@scalex86.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.