From: Arjan van de Ven <arjan@infradead.org>
To: Laurent CARON <lcaron@apartia.fr>
Cc: linux-kernel-Mailing-list <linux-kernel@vger.kernel.org>
Subject: Re: New revision of promise TX4
Date: Mon, 23 May 2005 15:53:39 +0200 [thread overview]
Message-ID: <1116856420.6280.28.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <4291DDA5.3070706@apartia.fr>
On Mon, 2005-05-23 at 15:41 +0200, Laurent CARON wrote:
> Hello,
>
> I recently bought a TX-4 which seems to be using a new chip (PCI ID:
> 105A:3519).
>
> It was not supported by the kernel so i added those lines to promise_sata.c
>
> diff sata_promise.c /usr/src/linux-2.6.11.9/drivers/scsi/sata_promise.c
> 170,171d169
> < { PCI_VENDOR_ID_PROMISE, 0x3519, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> < board_20319 },
>
>
> Is it the 'right' way?
if it works.. almost
the "right" way is to use "diff -purN" instead of just plain diff (it's
custom) and to do the files the other way around (again custom).
If you want to make it nice you add a PCI_ID_... constant for 0x3519 to
the header and use the symbolic constant in your code instead.
Greetings,
Arjan van de Ven
next prev parent reply other threads:[~2005-05-23 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-23 13:41 New revision of promise TX4 Laurent CARON
2005-05-23 13:53 ` Arjan van de Ven [this message]
2005-05-23 13:57 ` Laurent CARON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1116856420.6280.28.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=lcaron@apartia.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.