All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent CARON <lcaron@apartia.fr>
To: linux-kernel-Mailing-list <linux-kernel@vger.kernel.org>
Cc: Arjan van de Ven <arjan@infradead.org>
Subject: Re: New revision of promise TX4
Date: Mon, 23 May 2005 15:57:40 +0200	[thread overview]
Message-ID: <4291E154.7020101@apartia.fr> (raw)
In-Reply-To: <1116856420.6280.28.camel@laptopd505.fenrus.org>

Arjan van de Ven a écrit :

>if it works.. almost
>the "right" way is to use "diff -purN" instead of just plain diff (it's
>custom) and to do the files the other way around (again custom). 
>  
>
diff -purN /usr/src/linux-2.6.11.9/drivers/scsi/sata_promise.c 
sata_promise.c
--- /usr/src/linux-2.6.11.9/drivers/scsi/sata_promise.c 2005-05-12 
00:42:30.000000000 +0200
+++ sata_promise.c      2005-05-23 15:56:09.000000000 +0200
@@ -167,6 +167,8 @@ static struct pci_device_id pdc_ata_pci_
          board_20319 },
        { PCI_VENDOR_ID_PROMISE, 0x3d18, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
          board_20319 },
+       { PCI_VENDOR_ID_PROMISE, 0x3519, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
+         board_20319 },

        { }     /* terminate list */
 };


>If you want to make it nice you add a PCI_ID_... constant for 0x3519 to
>the header and use the symbolic constant in your code instead.
>  
>
I did it like this mainly because the file was built like this (without 
pci ids in the header).

Regards,

Laurent

      reply	other threads:[~2005-05-23 13:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-23 13:41 New revision of promise TX4 Laurent CARON
2005-05-23 13:53 ` Arjan van de Ven
2005-05-23 13:57   ` Laurent CARON [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4291E154.7020101@apartia.fr \
    --to=lcaron@apartia.fr \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.