All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>,
	B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org,
	linux-ide@vger.kernel.org
Subject: Re: [2.6 patch] drivers/ide/: possible cleanups
Date: Tue, 31 May 2005 07:44:36 +1000	[thread overview]
Message-ID: <1117489476.5194.6.camel@gaston> (raw)
In-Reply-To: <20050530205631.GP10441@stusta.de>

On Mon, 2005-05-30 at 22:56 +0200, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - pci/cy82c693.c: make a needlessly global function static
> - remove the following unneeded EXPORT_SYMBOL's:
>   - ide-taskfile.c: do_rw_taskfile
>   - ide-iops.c: default_hwif_iops
>   - ide-iops.c: default_hwif_transport
>   - ide-iops.c: wait_for_ready

Are we sure we want to do that ? That would mean never having IDE host
controller drivers as modules...

I was thinking about toying with that again for pmac one of these
days ...

It may be worth, however, to rename those exported symbols to ide_*

Ben.


  reply	other threads:[~2005-05-30 21:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-30 20:56 [2.6 patch] drivers/ide/: possible cleanups Adrian Bunk
2005-05-30 21:44 ` Benjamin Herrenschmidt [this message]
2005-05-30 21:57   ` Adrian Bunk
  -- strict thread matches above, loose matches on Subject: below --
2005-11-03 18:14 Adrian Bunk
2005-11-09 22:07 ` Bartlomiej Zolnierkiewicz
2005-10-01 15:53 Adrian Bunk
2005-08-20 19:02 Adrian Bunk
2005-04-30 20:07 Adrian Bunk
2005-05-01 13:37 ` Alan Cox
2005-05-01 14:29   ` Adrian Bunk
2005-05-02  1:27     ` Benjamin Herrenschmidt
2005-04-17 20:02 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1117489476.5194.6.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.