From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: [2.6 patch] drivers/ide/: possible cleanups
Date: Sat, 30 Apr 2005 22:07:50 +0200 [thread overview]
Message-ID: <20050430200750.GM3571@stusta.de> (raw)
This patch contains the following possible cleanups:
- pci/cy82c693.c: make a needlessly global function static
- remove the following unneeded EXPORT_SYMBOL's:
- ide-taskfile.c: do_rw_taskfile
- ide-iops.c: default_hwif_iops
- ide-iops.c: default_hwif_transport
- ide-iops.c: wait_for_ready
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 17 Apr 2005
drivers/ide/ide-iops.c | 6 ------
drivers/ide/ide-taskfile.c | 2 --
drivers/ide/pci/cy82c693.c | 2 +-
3 files changed, 1 insertion(+), 9 deletions(-)
--- linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c.old 2005-02-05 02:57:03.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c 2005-02-05 02:57:12.000000000 +0100
@@ -161,8 +161,6 @@
return ide_stopped;
}
-EXPORT_SYMBOL(do_rw_taskfile);
-
/*
* set_multmode_intr() is invoked on completion of a WIN_SETMULT cmd.
*/
--- linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c.old 2005-04-17 21:11:22.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c 2005-04-17 21:11:30.000000000 +0200
@@ -469,7 +469,7 @@
static __initdata ide_hwif_t *primary;
-void __init init_iops_cy82c693(ide_hwif_t *hwif)
+static void __init init_iops_cy82c693(ide_hwif_t *hwif)
{
if (PCI_FUNC(hwif->pci_dev->devfn) == 1)
primary = hwif;
--- linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c.old 2005-04-17 21:12:44.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c 2005-04-17 21:12:54.000000000 +0200
@@ -104,8 +104,6 @@
hwif->INSL = ide_insl;
}
-EXPORT_SYMBOL(default_hwif_iops);
-
/*
* MMIO operations, typically used for SATA controllers
*/
@@ -329,8 +327,6 @@
hwif->atapi_output_bytes = atapi_output_bytes;
}
-EXPORT_SYMBOL(default_hwif_transport);
-
/*
* Beginning of Taskfile OPCODE Library and feature sets.
*/
@@ -525,8 +525,6 @@
return 0;
}
-EXPORT_SYMBOL(wait_for_ready);
-
/*
* This routine busy-waits for the drive status to be not "busy".
* It then checks the status for all of the "good" bits and none
next reply other threads:[~2005-04-30 20:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-30 20:07 Adrian Bunk [this message]
2005-05-01 13:37 ` [2.6 patch] drivers/ide/: possible cleanups Alan Cox
2005-05-01 14:29 ` Adrian Bunk
2005-05-02 1:27 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2005-11-03 18:14 Adrian Bunk
2005-11-09 22:07 ` Bartlomiej Zolnierkiewicz
2005-10-01 15:53 Adrian Bunk
2005-08-20 19:02 Adrian Bunk
2005-05-30 20:56 Adrian Bunk
2005-05-30 21:44 ` Benjamin Herrenschmidt
2005-05-30 21:57 ` Adrian Bunk
2005-04-17 20:02 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050430200750.GM3571@stusta.de \
--to=bunk@stusta.de \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=akpm@osdl.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.