All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: David Howells <dhowells@redhat.com>
Cc: viro@zeniv.linux.org.uk, linux-block@vger.kernel.org,
	squashfs-devel@lists.sourceforge.net,
	Marek Vasut <marek.vasut@gmail.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Nicolas Pitre <nico@linaro.org>,
	Boris Brezillon <bbrezillon@kernel.org>,
	linux-mtd@lists.infradead.org,
	David Woodhouse <dwmw2@infradead.org>,
	Phillip Lougher <phillip@squashfs.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/6] Convert mount_single-using filesystems to fs_context
Date: Thu, 21 Mar 2019 17:34:40 +0100	[thread overview]
Message-ID: <11178040.rrurhZOAV8@blindfold> (raw)
In-Reply-To: <19628.1553183102@warthog.procyon.org.uk>

Am Donnerstag, 21. März 2019, 16:45:02 CET schrieb David Howells:
> Richard Weinberger <richard@nod.at> wrote:
> 
> > > Bah.  The problem is that vfs_get_super() doesn't set fc->root before
> > > calling reconfigure_super().
> > 
> > Do you still need the disassembly?
> 
> Thanks, but no.  I've pushed replacement patches to my git branch.

Just gave it a try, jffs2 does not mount anymore. The problem is that you define
an Opt_source in super.c, but never evaluate it -> jffs2_parse_param() returns
-EINVAL.

What I really don't get is the new logging stuff in include/linux/fs_context.h.
printk() is already an overloaded beat, why another layer?

The log output seems very odd to me:
[   13.117593] e MTD: Couldn't look up '/dev/mtd0': -15

Please notice the "e" before MTD, first I though this is a memory
corruption, but is your log level?!

Thanks,
//richard



WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: David Howells <dhowells@redhat.com>
Cc: squashfs-devel@lists.sourceforge.net,
	Nicolas Pitre <nico@linaro.org>,
	Boris Brezillon <bbrezillon@kernel.org>,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	Marek Vasut <marek.vasut@gmail.com>,
	linux-mtd@lists.infradead.org, viro@zeniv.linux.org.uk,
	linux-fsdevel@vger.kernel.org,
	Phillip Lougher <phillip@squashfs.org.uk>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [RFC PATCH 0/6] Convert mount_single-using filesystems to fs_context
Date: Thu, 21 Mar 2019 17:34:40 +0100	[thread overview]
Message-ID: <11178040.rrurhZOAV8@blindfold> (raw)
In-Reply-To: <19628.1553183102@warthog.procyon.org.uk>

Am Donnerstag, 21. März 2019, 16:45:02 CET schrieb David Howells:
> Richard Weinberger <richard@nod.at> wrote:
> 
> > > Bah.  The problem is that vfs_get_super() doesn't set fc->root before
> > > calling reconfigure_super().
> > 
> > Do you still need the disassembly?
> 
> Thanks, but no.  I've pushed replacement patches to my git branch.

Just gave it a try, jffs2 does not mount anymore. The problem is that you define
an Opt_source in super.c, but never evaluate it -> jffs2_parse_param() returns
-EINVAL.

What I really don't get is the new logging stuff in include/linux/fs_context.h.
printk() is already an overloaded beat, why another layer?

The log output seems very odd to me:
[   13.117593] e MTD: Couldn't look up '/dev/mtd0': -15

Please notice the "e" before MTD, first I though this is a memory
corruption, but is your log level?!

Thanks,
//richard



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2019-03-21 16:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 11:50 [RFC PATCH 0/6] Convert mount_single-using filesystems to fs_context David Howells
2019-03-21 11:50 ` David Howells
2019-03-21 11:50 ` [RFC PATCH 1/6] mtd: Provide fs_context-aware mount_mtd() replacement David Howells
2019-03-21 11:50   ` David Howells
2019-03-21 11:50 ` [RFC PATCH 2/6] romfs: Convert to fs_context David Howells
2019-03-21 11:50   ` David Howells
2019-03-21 11:50 ` [RFC PATCH 3/6] cramfs: " David Howells
2019-03-21 11:50   ` David Howells
2019-03-21 11:50 ` [RFC PATCH 4/6] jffs2: " David Howells
2019-03-21 11:50   ` David Howells
2019-03-21 11:52 ` [RFC PATCH 0/6] Convert mount_single-using filesystems " David Howells
2019-03-21 11:52   ` David Howells
2019-03-21 12:48 ` Richard Weinberger
2019-03-21 12:48   ` Richard Weinberger
2019-03-21 15:12   ` David Howells
2019-03-21 15:12     ` David Howells
2019-03-21 15:16   ` David Howells
2019-03-21 15:16     ` David Howells
2019-03-21 15:41     ` Richard Weinberger
2019-03-21 15:41       ` Richard Weinberger
2019-03-21 15:45       ` David Howells
2019-03-21 15:45         ` David Howells
2019-03-21 16:34         ` Richard Weinberger [this message]
2019-03-21 16:34           ` Richard Weinberger
2019-03-21 17:06           ` David Howells
2019-03-21 17:06             ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11178040.rrurhZOAV8@blindfold \
    --to=richard@nod.at \
    --cc=bbrezillon@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=nico@linaro.org \
    --cc=phillip@squashfs.org.uk \
    --cc=squashfs-devel@lists.sourceforge.net \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.