All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: brking@us.ibm.com
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>, haren@us.ibm.com
Subject: Re: [PATCH 1/1] ipr: Fix for adapter shutdown issue
Date: Wed, 15 Jun 2005 11:44:59 -0500	[thread overview]
Message-ID: <1118853899.5045.39.camel@mulgrave> (raw)
In-Reply-To: <42B05330.7050406@us.ibm.com>

On Wed, 2005-06-15 at 11:11 -0500, Brian King wrote:
> System crash and controlled power off are two different things. Yes, if the
> adapter is not told about the shutdown so it can flush its cache, the
> data will be maintained, but it can only be maintained for as long as
> the battery lasts. Currently, with 2.6.12-rc, if you do a normal power off
> and leave the system powered off for a long enough period of time (usually
> a week or so, depending on the battery on the card), you will suffer data
> loss. This is not acceptable. With 2.6.11, the adapter is told to flush
> the write cache on a controlled power off, so the system can remain powered
> off indefinitely with no data loss.
> 
> Regarding supporting the sync cache command to a disk array, I did consider
> requesting support be added to the adapter microcode, but decided against it
> since it would make a RAID array perform horribly and it did not seem to be
> the appropriate model to follow for NV write cache. Some of the ipr adapters
> have over 500 MB of write cache, which can take an awful long time to flush,
> much longer than you would want for a journal barrier. So, all the barrier/
> SYNC_CACHE code works great for a volatile write cache on a disk, but
> doesn't necessarily seem like the best model for large non-volatile write
> caches for RAID adapters.

Well, I still think you're operating unsafely ... some people let these
batteries run out, you know ...

To fix this, add a

blk_queue_ordered(sdev->request_queue, QUEUE_ORDERED_NONE);

to the slave configure routine for each of the devices that doesn't
synchronize the cache.  That should correct the SCSI layer assumptions.

James



  reply	other threads:[~2005-06-15 16:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-15 15:15 [PATCH 1/1] ipr: Fix for adapter shutdown issue brking
2005-06-15 15:17 ` Christoph Hellwig
2005-06-15 16:01   ` Greg KH
2005-06-15 16:14     ` Brian King
2005-06-15 15:28 ` James Bottomley
2005-06-15 15:34   ` Brian King
2005-06-15 15:47     ` James Bottomley
2005-06-15 16:11       ` Brian King
2005-06-15 16:44         ` James Bottomley [this message]
2005-06-15 17:05           ` Patrick Mansfield
2005-06-15 17:23             ` James Bottomley
2005-06-16 12:00               ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1118853899.5045.39.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=brking@us.ibm.com \
    --cc=haren@us.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.