From: Patrick Mansfield <patmans@us.ibm.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: brking@us.ibm.com, SCSI Mailing List <linux-scsi@vger.kernel.org>,
haren@us.ibm.com
Subject: Re: [PATCH 1/1] ipr: Fix for adapter shutdown issue
Date: Wed, 15 Jun 2005 10:05:45 -0700 [thread overview]
Message-ID: <20050615170545.GB23912@us.ibm.com> (raw)
In-Reply-To: <1118853899.5045.39.camel@mulgrave>
On Wed, Jun 15, 2005 at 11:44:59AM -0500, James Bottomley wrote:
>
> Well, I still think you're operating unsafely ... some people let these
> batteries run out, you know ...
>
> To fix this, add a
>
> blk_queue_ordered(sdev->request_queue, QUEUE_ORDERED_NONE);
>
> to the slave configure routine for each of the devices that doesn't
> synchronize the cache. That should correct the SCSI layer assumptions.
I don't get it.
First in scsi_alloc_queue, the flush/sync code is only used if we don't
have ordered tags, and if the adapter driver explicitly allows it
(shost->order_flush).
Plus we clear order_flush in scsi_host_alloc if can_queue > 1.
So ipr will never get those sync cache commands, correct?
And we default to QUEUE_ORDERED_NONE (0) if ordered_tag and ordered_flush
are not set.
But I can't find any where that we set ordered_tag at all, am I missing
something??? Let alone in ipr.
-- Patrick Mansfield
next prev parent reply other threads:[~2005-06-15 17:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-15 15:15 [PATCH 1/1] ipr: Fix for adapter shutdown issue brking
2005-06-15 15:17 ` Christoph Hellwig
2005-06-15 16:01 ` Greg KH
2005-06-15 16:14 ` Brian King
2005-06-15 15:28 ` James Bottomley
2005-06-15 15:34 ` Brian King
2005-06-15 15:47 ` James Bottomley
2005-06-15 16:11 ` Brian King
2005-06-15 16:44 ` James Bottomley
2005-06-15 17:05 ` Patrick Mansfield [this message]
2005-06-15 17:23 ` James Bottomley
2005-06-16 12:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050615170545.GB23912@us.ibm.com \
--to=patmans@us.ibm.com \
--cc=James.Bottomley@SteelEye.com \
--cc=brking@us.ibm.com \
--cc=haren@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.