All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@cyclades.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Christoph Lameter <christoph@lameter.com>,
	Linux Memory Management <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	raybry@engr.sgi.com, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [RFC] Fix SMP brokenness for PF_FREEZE and make freezing usable for other purposes
Date: Sun, 26 Jun 2005 20:54:14 +1000	[thread overview]
Message-ID: <1119783254.8083.5.camel@localhost> (raw)
In-Reply-To: <20050626023053.GA2871@atrey.karlin.mff.cuni.cz>

Hi!

On Sun, 2005-06-26 at 12:30, Pavel Machek wrote:
> > Index: linux-2.6.12/arch/i386/kernel/signal.c
> > ===================================================================
> > --- linux-2.6.12.orig/arch/i386/kernel/signal.c	2005-06-25 05:01:26.000000000 +0000
> > +++ linux-2.6.12/arch/i386/kernel/signal.c	2005-06-25 05:01:28.000000000 +0000
> > @@ -608,10 +608,8 @@ int fastcall do_signal(struct pt_regs *r
> >  	if (!user_mode(regs))
> >  		return 1;
> >  
> > -	if (current->flags & PF_FREEZE) {
> > -		refrigerator(0);
> > +	if (try_to_freeze)
> >  		goto no_signal;
> > -	}
> >  
> 
> This is not good. Missing ().

Thanks!

I was just going to begin a search to find out why, after applying it,
everything stopped dead in the water :>

Nigel


WARNING: multiple messages have this Message-ID (diff)
From: Nigel Cunningham <ncunningham@cyclades.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Christoph Lameter <christoph@lameter.com>,
	Linux Memory Management <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	raybry@engr.sgi.com, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [RFC] Fix SMP brokenness for PF_FREEZE and make freezing usable for other purposes
Date: Sun, 26 Jun 2005 20:54:14 +1000	[thread overview]
Message-ID: <1119783254.8083.5.camel@localhost> (raw)
In-Reply-To: <20050626023053.GA2871@atrey.karlin.mff.cuni.cz>

Hi!

On Sun, 2005-06-26 at 12:30, Pavel Machek wrote:
> > Index: linux-2.6.12/arch/i386/kernel/signal.c
> > ===================================================================
> > --- linux-2.6.12.orig/arch/i386/kernel/signal.c	2005-06-25 05:01:26.000000000 +0000
> > +++ linux-2.6.12/arch/i386/kernel/signal.c	2005-06-25 05:01:28.000000000 +0000
> > @@ -608,10 +608,8 @@ int fastcall do_signal(struct pt_regs *r
> >  	if (!user_mode(regs))
> >  		return 1;
> >  
> > -	if (current->flags & PF_FREEZE) {
> > -		refrigerator(0);
> > +	if (try_to_freeze)
> >  		goto no_signal;
> > -	}
> >  
> 
> This is not good. Missing ().

Thanks!

I was just going to begin a search to find out why, after applying it,
everything stopped dead in the water :>

Nigel

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  parent reply	other threads:[~2005-06-26 10:53 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-24 20:20 [RFC] Fix SMP brokenness for PF_FREEZE and make freezing usable for other purposes Christoph Lameter
2005-06-24 20:20 ` Christoph Lameter
2005-06-24 22:25 ` Nigel Cunningham
2005-06-24 22:25   ` Nigel Cunningham
2005-06-25  2:51 ` Pavel Machek
2005-06-25  2:51   ` Pavel Machek
2005-06-25  4:31   ` Christoph Lameter
2005-06-25  4:31     ` Christoph Lameter
2005-06-25  4:46     ` Nigel Cunningham
2005-06-25  4:46       ` Nigel Cunningham
2005-06-25 22:37     ` Pavel Machek
2005-06-25 22:37       ` Pavel Machek
2005-06-25  6:13   ` Christoph Lameter
2005-06-25  6:13     ` Christoph Lameter
2005-06-26  2:30     ` Pavel Machek
2005-06-26  2:30       ` Pavel Machek
2005-06-26  2:55       ` Christoph Lameter
2005-06-26  2:55         ` Christoph Lameter
2005-06-26  3:09         ` Pavel Machek
2005-06-26  3:09           ` Pavel Machek
2005-06-27  3:51           ` Christoph Lameter
2005-06-27  3:51             ` Christoph Lameter
2005-06-27  4:21             ` Pavel Machek
2005-06-27  4:21               ` Pavel Machek
2005-06-27  4:24             ` Linus Torvalds
2005-06-27  4:24               ` Linus Torvalds
2005-06-27  5:53               ` Christoph Lameter
2005-06-27  5:53                 ` Christoph Lameter
2005-06-27 14:13                 ` Pavel Machek
2005-06-27 14:13                   ` Pavel Machek
2005-06-27 15:13                   ` Christoph Lameter
2005-06-27 15:13                     ` Christoph Lameter
2005-06-28  6:18                     ` Kirill Korotaev
2005-06-28  6:18                       ` Kirill Korotaev
2005-06-28  7:01                       ` Christoph Lameter
2005-06-28  7:01                         ` Christoph Lameter
2005-06-28  7:30                         ` Kirill Korotaev
2005-06-28  7:30                           ` Kirill Korotaev
2005-06-28  8:13                           ` Kirill Korotaev
2005-06-28  8:13                             ` Kirill Korotaev
2005-06-28 14:02                             ` Christoph Lameter
2005-06-28 14:02                               ` Christoph Lameter
2005-06-28 14:01                           ` Christoph Lameter
2005-06-28 14:01                             ` Christoph Lameter
2005-06-28 12:47                       ` Pavel Machek
2005-06-28 12:47                         ` Pavel Machek
2005-07-01 17:06                         ` [SUSPEND 1/2]Replace PF_FREEZE with TIF_FREEZE Christoph Lameter
2005-07-01 17:06                           ` Christoph Lameter
2005-07-01 17:14                           ` [SUSPEND 2/2] Replace PF_FROZEN with TASK_FROZEN Christoph Lameter
2005-07-01 17:14                             ` Christoph Lameter
2005-06-28 21:50                 ` [RFC] Fix SMP brokenness for PF_FREEZE and make freezing usable for other purposes Ray Bryant
2005-06-28 21:50                   ` Ray Bryant
2005-06-28 21:54                   ` Christoph Lameter
2005-06-28 21:54                     ` Christoph Lameter
2005-07-03 11:06                     ` Pavel Machek
2005-07-03 11:06                       ` Pavel Machek
2005-06-26 10:54       ` Nigel Cunningham [this message]
2005-06-26 10:54         ` Nigel Cunningham
2005-06-25  6:18   ` Christoph Lameter
2005-06-25  6:18     ` Christoph Lameter
2005-06-25  7:35 ` Kirill Korotaev
2005-06-25  7:35   ` Kirill Korotaev
2005-06-27  7:06   ` Ray Bryant
2005-06-27  7:06     ` Ray Bryant
2005-06-27 13:17     ` Pavel Machek
2005-06-27 13:17       ` Pavel Machek
2005-06-27 14:59       ` Ray Bryant
2005-06-27 14:59         ` Ray Bryant
2005-06-27 18:05         ` Pavel Machek
2005-06-27 18:05           ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1119783254.8083.5.camel@localhost \
    --to=ncunningham@cyclades.com \
    --cc=christoph@lameter.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pavel@ucw.cz \
    --cc=raybry@engr.sgi.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.