[KJ] kernel/module.c use __set_current_state() instead of direct

[KJ] kernel/module.c use __set_current_state() instead of direct

[aLeJ]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Description:
Use of __set_current_state() instead of direct assigment of
current->state.

Signed-off-by: Alejandro Andres <fuzzy.alej@gmail.com>

--- linux-2.6.12.1/kernel/module.c.orig	2005-06-29 20:11:28.000000000
+0200
+++ linux-2.6.12.1/kernel/module.c	2005-06-29 20:12:02.000000000 +0200
@@ -518,7 +518,7 @@ static void wait_for_zero_refcount(struc
 			break;
 		schedule();
 	}
-	current->state = TASK_RUNNING;
+	__set_current_state(TASK_RUNNING);
 	down(&module_mutex);
 }
 



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] kernel/module.c use __set_current_state() instead of direct

[Nico Golde]

[-- Attachment #1.1: Type: text/plain, Size: 938 bytes --]

Hi,
* aLeJ <fuzzy.alej@gmail.com> [2005-06-29 19:00]:
> Description:
> Use of __set_current_state() instead of direct assigment of
> current->state.
> 
> Signed-off-by: Alejandro Andres <fuzzy.alej@gmail.com>
> 
> --- linux-2.6.12.1/kernel/module.c.orig	2005-06-29 20:11:28.000000000
> +0200
> +++ linux-2.6.12.1/kernel/module.c	2005-06-29 20:12:02.000000000 +0200
> @@ -518,7 +518,7 @@ static void wait_for_zero_refcount(struc
>  			break;
>  		schedule();
>  	}
> -	current->state = TASK_RUNNING;
> +	__set_current_state(TASK_RUNNING);
>  	down(&module_mutex);
>  }

There are many current->state code snippets in the kernel
source. Should they all be substituted?
Regards Nico
-- 
Nico Golde - JAB: nion@jabber.ccc.de | GPG: 0x73647CFF
http://www.ngolde.de | http://www.muttng.org | http://grml.org 
VIM has two modes - the one in which it beeps 
and the one in which it doesn't -- encrypted mail preferred

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors