[U-Boot-Users] Statuc code format for USB response...

[U-Boot-Users] Statuc code format for USB response...

[Neil Bryan]

This is a trivial comment, but helpful for developers not expert in
debugging USB-related problems.

After issuing the following command:

U-Boot> usb reset

I obtained the following result:

      USB device not responding, giving up (status=20)

The code responsible for this is in ./common/usb.c and 
shown below:

printf("\n      USB device not responding, giving up
(status=%lX)\n",dev->status);

I _believe_ the status code returned is that defined in 
./include/usb_defs.h and that my status code of 20 is 
the value defined by the macro USB_ST_CRC_ERR.

The printf uses a %lX format specifier and it would be improved
if it was proceeded with an '0x' to inform the developer (me) 
that this is indeed a hexadecimal value.  My suggested change is

In ./common/usb.c
--------------
- printf("\n      USB device not responding, giving up
(status=%lX)\n",dev->status)
+ printf("\n      USB device not responding, giving up
(status=0x%lX)\n",dev->status)
--------------

As I said, I know this is trivial, but every little bit of 
extra information helps when debugging something that is
unfamiliar.

Flames and other comments gratefully received!

Regards,

Neil Bryan.

[U-Boot-Users] Statuc code format for USB response...

[Wolfgang Denk]

In message <1120638436.6064.32.camel@daroca> you wrote:
> This is a trivial comment, but helpful for developers not expert in
> debugging USB-related problems.

There are several serious problems with the  existing  USB  code.  We
have some patches in test which whill be checked in soon.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Name one thing windows is better than unix in?
                                          Making money for Microsoft?
         -- Randal L. Schwartz in <8cvi5t4c3t.fsf@gadget.cscaper.com>