From: Dave Hansen <haveblue@us.ibm.com>
To: Ravikiran G Thirumalai <kiran@scalex86.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
shai@scalex86.org
Subject: Re: [patch] mm: Ensure proper alignment for node_remap_start_pfn
Date: Thu, 28 Jul 2005 10:20:26 -0700 [thread overview]
Message-ID: <1122571226.23386.44.camel@localhost> (raw)
In-Reply-To: <20050728013134.GB23923@localhost.localdomain>
On Wed, 2005-07-27 at 18:31 -0700, Ravikiran G Thirumalai wrote:
> On Wed, Jul 27, 2005 at 06:17:24PM -0700, Andrew Morton wrote:
> > Ravikiran G Thirumalai <kiran@scalex86.org> wrote:
> > >
> > > While reserving KVA for lmem_maps of node, we have to make sure that
> > > node_remap_start_pfn[] is aligned to a proper pmd boundary.
> > > (node_remap_start_pfn[] gets its value from node_end_pfn[])
> > >
> >
> > What are the effects of not having this patch applied? Does someone's
> > computer crash, or what?
>
> Yes, it does cause a crash.
I don't know of any NUMA x86 sub-arches that have nodes which are
aligned on any less than 2MB. Is this an architecture that's supported
in the tree, today?
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Ravikiran G Thirumalai <kiran@scalex86.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
shai@scalex86.org
Subject: Re: [patch] mm: Ensure proper alignment for node_remap_start_pfn
Date: Thu, 28 Jul 2005 10:20:26 -0700 [thread overview]
Message-ID: <1122571226.23386.44.camel@localhost> (raw)
In-Reply-To: <20050728013134.GB23923@localhost.localdomain>
On Wed, 2005-07-27 at 18:31 -0700, Ravikiran G Thirumalai wrote:
> On Wed, Jul 27, 2005 at 06:17:24PM -0700, Andrew Morton wrote:
> > Ravikiran G Thirumalai <kiran@scalex86.org> wrote:
> > >
> > > While reserving KVA for lmem_maps of node, we have to make sure that
> > > node_remap_start_pfn[] is aligned to a proper pmd boundary.
> > > (node_remap_start_pfn[] gets its value from node_end_pfn[])
> > >
> >
> > What are the effects of not having this patch applied? Does someone's
> > computer crash, or what?
>
> Yes, it does cause a crash.
I don't know of any NUMA x86 sub-arches that have nodes which are
aligned on any less than 2MB. Is this an architecture that's supported
in the tree, today?
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-07-28 17:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-28 0:42 [patch] mm: Ensure proper alignment for node_remap_start_pfn Ravikiran G Thirumalai
2005-07-28 0:42 ` Ravikiran G Thirumalai
2005-07-28 1:17 ` Andrew Morton
2005-07-28 1:17 ` Andrew Morton
2005-07-28 1:31 ` Ravikiran G Thirumalai
2005-07-28 1:31 ` Ravikiran G Thirumalai
2005-07-28 17:20 ` Dave Hansen [this message]
2005-07-28 17:20 ` Dave Hansen
2005-07-28 18:14 ` Ravikiran G Thirumalai
2005-07-28 18:14 ` Ravikiran G Thirumalai
2005-07-28 18:25 ` Dave Hansen
2005-07-28 18:25 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1122571226.23386.44.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shai@scalex86.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.