[U-Boot-Users] [PATCH] AMD/Spansion write buffer support in cfi_flash.c

[U-Boot-Users] [PATCH] AMD/Spansion write buffer support in cfi_flash.c

[Alex BASTOS]

Hi,

This patch:
 - Adds flash_write_cfibuffer support for AMD/Spansion Flashes.
 - Additionally, adds 8BIT AMD/Spansion support

This is a mix and resend, following the recent rules from
U-boot Developers Information, of two similar patches from
Thomas Sch?fer and me.

Bests regards,

Alex BASTOS
-----

Signed-off-by: Thomas Schaefer <thomas.schaefer@kontron.com>
Signed-off-by: Alexandre Bastos <alebas@televes.com>

CHANGELOG:
* Add support for AMD/Spansion Flashes in flash_write_cfibuffer
  Patch by Alex Bastos and Thomas Schaefer, 2005-08-29

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20050829_cfi_flash.diff
Type: text/x-patch
Size: 7136 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050829/34cf5e3b/attachment.bin 

[U-Boot-Users] [PATCH] AMD/Spansion write buffer support in cfi_flash.c

[Yuli Barcohen]

>>>>> Alex BASTOS writes:

    Alex> This patch:
    Alex> - Adds flash_write_cfibuffer support for AMD/Spansion Flashes.
    Alex> - Additionally, adds 8BIT AMD/Spansion support

...

8-bit AMD/Spansion flashes are supported by current driver. The patch
would, in fact, break support for many such flashes (29F016D, for
example). Only in a special case of 16-bit flash configured to work in
8-bit mode (29DL640D in 8-bot mode, for example), such a change in
command address can be needed but IMHO this should be handled in
run-time according to CFI info.

-- 
========================================================================
 Yuli Barcohen       | Phone +972-9-765-1788 |  Software Project Leader
 yuli at arabellasw.com | Fax   +972-9-765-7494 | Arabella Software, Israel
========================================================================

[U-Boot-Users] [PATCH] AMD/Spansion write buffer support in cfi_flash.c

[Wolfgang Denk]

In message <1125312049.4312e63166b13@webmail.televes.com:443> you wrote:
> 
> This patch:
>  - Adds flash_write_cfibuffer support for AMD/Spansion Flashes.
>  - Additionally, adds 8BIT AMD/Spansion support

Please split this into two separate patches.

> This is a mix and resend, following the recent rules from
> U-boot Developers Information, of two similar patches from
> Thomas Sch?fer and me.

This information read:

	(2) Make separate commits for logically separate changes.

As Yuli already pointed out, the  8bit  part  of  the  patch  is  not
acceptable as is.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Wenn Du ein' weise Antwort verlangst, Mu?t Du vern?nftig fragen.
                                                -- Goethe, Invektiven

[U-Boot-Users] [PATCH] AMD/Spansion write buffer support in cfi_flash.c

[Alex BASTOS]

> 8-bit AMD/Spansion flashes are supported by current driver. The patch
> would, in fact, break support for many such flashes (29F016D, for
> example). Only in a special case of 16-bit flash configured to work in
> 8-bit mode (29DL640D in 8-bot mode, for example), such a change in
> command address can be needed but IMHO this should be handled in
> run-time according to CFI info.
>

Ummm, such a change is needed at least by S29GLxxxM flashes, but
I didn't know anything about 29F016D. Sorry about that.
Any suggestion as info from to CFI which would select the correct
command addresses?

Best regards,

Alex BASTOS

[U-Boot-Users] [PATCH] AMD/Spansion write buffer support in cfi_flash.c

[Alex BASTOS]

> >  - Adds flash_write_cfibuffer support for AMD/Spansion Flashes.
> >  - Additionally, adds 8BIT AMD/Spansion support
>
> Please split this into two separate patches.

OK, I will when corrected

>
> > This is a mix and resend, following the recent rules from
> > U-boot Developers Information, of two similar patches from
> > Thomas Sch?fer and me.
>
> This information read:
>
> 	(2) Make separate commits for logically separate changes.

Sorry. They were closely related for me.


Best regards,

Alex BASTOS

[U-Boot-Users] [PATCH] AMD/Spansion write buffer support in cfi_flash.c

[Yuli Barcohen]

>>>>> Alex BASTOS writes:

    Yuli> 8-bit AMD/Spansion flashes are supported by current
    Yuli> driver. The patch would, in fact, break support for many such
    Yuli> flashes (29F016D, for example). Only in a special case of
    Yuli> 16-bit flash configured to work in 8-bit mode (29DL640D in
    Yuli> 8-bot mode, for example), such a change in command address can
    Yuli> be needed but IMHO this should be handled in run-time
    Yuli> according to CFI info.

    Alex> Ummm, such a change is needed at least by S29GLxxxM flashes,

It's exactly the case which I mentioned: dual-mode (x8/x16) flash in
8-bit mode.

    Alex> but I didn't know anything about 29F016D. Sorry about that.
    Alex> Any suggestion as info from to CFI which would select the
    Alex> correct command addresses?

There is a field in CFI information table which specifies flash
interface (offset 0x50 in 8-bit mode, page 53 of S29GLxxxM data
sheet). If the flash is x8/x16 and the driver detected that it's in
8-bit mode, this means that it's the above mentioned special case. I'd
add a couple of fields to U-Boot's CFI flash structure to hold the
addresses. Then simple shift would provide correct addresses.

-- 
========================================================================
 Yuli Barcohen       | Phone +972-9-765-1788 |  Software Project Leader
 yuli at arabellasw.com | Fax   +972-9-765-7494 | Arabella Software, Israel
========================================================================

[U-Boot-Users] [PATCH] AMD/Spansion write buffer support in cfi_flash.c

[alebas at televes.com]

Yuli,

>
> There is a field in CFI information table which specifies flash
> interface (offset 0x50 in 8-bit mode, page 53 of S29GLxxxM data
> sheet). If the flash is x8/x16 and the driver detected that it's in
> 8-bit mode, this means that it's the above mentioned special case. I'd
> add a couple of fields to U-Boot's CFI flash structure to hold the
> addresses. Then simple shift would provide correct addresses.
>

It may be enough shifting the address each time it is needed
(in fact, only two times).

Suggestions?

Alex BASTOS


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20050830_cfi_flash_B.diff
Type: text/x-patch
Size: 1512 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050830/d7f6910d/attachment.bin 

[U-Boot-Users] [PATCH] AMD/Spansion write buffer support in cfi_flash.c

[Wolfgang Denk]

In message <1125397553.43143431e3efa@webmail.televes.com:443> you wrote:
> 
> It may be enough shifting the address each time it is needed
> (in fact, only two times).
...
> Content-Type: text/x-patch; name="20050830_cfi_flash_B.diff"

Applied, thanks. But please provide a  proper  CHANGELOG  entry  next
time.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Imagination is more important than knowledge.      -- Albert Einstein