From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Dan Malek <dan@embeddededge.com>
Cc: Paul Mackerras <paulus@samba.org>,
linux-ppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] add big endian version of ld_/st_ IO access macros and convert main 8xx code to use it
Date: Thu, 08 Sep 2005 10:55:40 +1000 [thread overview]
Message-ID: <1126140940.29803.2.camel@gaston> (raw)
In-Reply-To: <00a1f47bb2edbbc001c2267191aa36f0@embeddededge.com>
On Wed, 2005-09-07 at 20:42 -0400, Dan Malek wrote:
> On Sep 7, 2005, at 8:28 PM, Benjamin Herrenschmidt wrote:
>
> > I'm not fan of the approach. You should use in_/out_ macros for IOs. If
> > you don't need eieio on 8xx , then just #ifdef it out of the
> > implementation of these.
>
> Yeah, #ifdef :-) That patch wouldn't go anywhere (well,
> to /dev/null perhaps).
Heh, it can be done properly: use an eieio() macro/inline and have
_that_ be #ifdef'ed to nothing on 8xx...
> We can just use the in_/out_ macros that are there. The eieio
> doesn't hurt anything on the 8xx.
Ok, in that case, I don't see any problem.
Ben.
next prev parent reply other threads:[~2005-09-08 0:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-07 23:03 [PATCH] add big endian version of ld_/st_ IO access macros and convert main 8xx code to use it Marcelo Tosatti
2005-09-08 0:28 ` Benjamin Herrenschmidt
2005-09-08 0:42 ` Dan Malek
2005-09-08 0:55 ` Benjamin Herrenschmidt [this message]
2005-09-08 0:58 ` Marcelo Tosatti
2005-09-08 4:27 ` Paul Mackerras
2005-09-08 13:56 ` Dan Malek
2005-09-08 19:34 ` Marcelo Tosatti
2005-09-08 0:51 ` Marcelo Tosatti
2005-09-08 1:14 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1126140940.29803.2.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=dan@embeddededge.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.