All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] [PATCH] hwmon: fix sis5595,
@ 2005-09-12 22:10 Greg KH
  0 siblings, 0 replies; only message in thread
From: Greg KH @ 2005-09-12 22:10 UTC (permalink / raw)
  To: lm-sensors

[PATCH] hwmon: fix sis5595, via686a force_addr module parameter

Recent changes to the i2c-isa design broke the force_addr parameter of
two hardware monitoring drivers as a side effect: sis5595 and via686a.
The last address test was in fact useless beforehand, and the redesign
turned it into a bug. I'm sorry about that.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
commit b51f64c0de0355338480093abb35d5232f6d349a
tree 5d72e0ef37629387c8613c2b48afadafbeaca6b4
parent 860e1d6b46bd4cbc67d8d065f0f682143513382f
author Jean Delvare <khali@linux-fr.org> Thu, 08 Sep 2005 22:42:36 +0200
committer Greg Kroah-Hartman <gregkh@suse.de> Fri, 09 Sep 2005 14:34:20 -0700

 drivers/hwmon/sis5595.c |    5 -----
 drivers/hwmon/via686a.c |    5 -----
 2 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/drivers/hwmon/sis5595.c b/drivers/hwmon/sis5595.c
--- a/drivers/hwmon/sis5595.c
+++ b/drivers/hwmon/sis5595.c
@@ -758,11 +758,6 @@ static int __devinit sis5595_pci_probe(s
 		return -ENODEV;
 	}
 
-	if (!address) {
-		dev_err(&dev->dev,"No SiS 5595 sensors found.\n");
-		return -ENODEV;
-	}
-
 	s_bridge = pci_dev_get(dev);
 	if (i2c_isa_add_driver(&sis5595_driver)) {
 		pci_dev_put(s_bridge);
diff --git a/drivers/hwmon/via686a.c b/drivers/hwmon/via686a.c
--- a/drivers/hwmon/via686a.c
+++ b/drivers/hwmon/via686a.c
@@ -812,11 +812,6 @@ static int __devinit via686a_pci_probe(s
 		return -ENODEV;
 	}
 
-	if (!address) {
-		dev_err(&dev->dev, "No Via 686A sensors found.\n");
-		return -ENODEV;
-	}
-
 	s_bridge = pci_dev_get(dev);
 	if (i2c_isa_add_driver(&via686a_driver)) {
 		pci_dev_put(s_bridge);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-09-12 22:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-12 22:10 [lm-sensors] [PATCH] hwmon: fix sis5595, Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.