* [Bridge] Re: [PATCH] TSO fix in br_dev_queue_push_xmit [not found] ` <20050921.001427.27575173.davem@davemloft.net> @ 2005-09-21 12:53 ` Vlad Drukker 2005-09-21 16:47 ` Stephen Hemminger 2005-09-23 6:36 ` David S. Miller 0 siblings, 2 replies; 3+ messages in thread From: Vlad Drukker @ 2005-09-21 12:53 UTC (permalink / raw) To: Stephen Hemminger, ;Henrik Nordstrom, ;David S. Miller; +Cc: bridge Hi, I see you all agree to apply :) Stephen, repost of this patch to proper places below. Thank you Henrik for clarification of bridge standard. However, silent drop of locally generated packets on 99% idle carrier grade machine looks like a hardware problem. David, don't you think that having software packet drop counters is a bad idea? I thought, software drop counters are there to help identify hardware problems or lack of resources. In this case, tcp stack produced output that just gone. TSO is there over years and no one even noticed given TSO/bridge conflict mainly because there is no stats. (IMHO) Let's blame standards, right? Signed-off-by : Vlad Drukker <vlad@storewiz.com> --- net/bridge/br_forward.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c --- a/net/bridge/br_forward.c +++ b/net/bridge/br_forward.c @@ -31,7 +31,8 @@ static inline int should_deliver(const s int br_dev_queue_push_xmit(struct sk_buff *skb) { - if (skb->len > skb->dev->mtu) + /* drop mtu oversized packets except tso */ + if (skb->len > skb->dev->mtu && !skb_shinfo(skb)->tso_size) kfree_skb(skb); else { #ifdef CONFIG_BRIDGE_NETFILTER ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bridge] Re: [PATCH] TSO fix in br_dev_queue_push_xmit 2005-09-21 12:53 ` [Bridge] Re: [PATCH] TSO fix in br_dev_queue_push_xmit Vlad Drukker @ 2005-09-21 16:47 ` Stephen Hemminger 2005-09-23 6:36 ` David S. Miller 1 sibling, 0 replies; 3+ messages in thread From: Stephen Hemminger @ 2005-09-21 16:47 UTC (permalink / raw) To: Vlad Drukker; +Cc: bridge, ; David S. Miller, ; Henrik Nordstrom On Wed, 21 Sep 2005 15:53:06 +0300 Vlad Drukker <vlad@storewiz.com> wrote: > Hi, > > I see you all agree to apply :) > > Stephen, repost of this patch to proper places below. > > Thank you Henrik for clarification of bridge standard. > However, silent drop of locally generated packets on 99% idle carrier > grade machine looks like a hardware problem. > > David, don't you think that having software packet drop counters is a > bad idea? I thought, software drop counters are there to help identify > hardware problems or lack of resources. In this case, tcp stack produced > output that just gone. TSO is there over years and no one even noticed > given TSO/bridge conflict mainly because there is no stats. (IMHO) > Let's blame standards, right? > Patch is fine. Putting in a counter would be good, but there is no good structure to put it in. The bridge device (br0) counters make sense for locally generated packets, the network devices (ethX) forwarding packets are under control of the other device driver. There is a whole bridge MIB defined in the standard, but adding it would be a lot of work, and not sure if anyone would care. ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bridge] Re: [PATCH] TSO fix in br_dev_queue_push_xmit 2005-09-21 12:53 ` [Bridge] Re: [PATCH] TSO fix in br_dev_queue_push_xmit Vlad Drukker 2005-09-21 16:47 ` Stephen Hemminger @ 2005-09-23 6:36 ` David S. Miller 1 sibling, 0 replies; 3+ messages in thread From: David S. Miller @ 2005-09-23 6:36 UTC (permalink / raw) To: vlad; +Cc: bridge, hno, shemminger From: Vlad Drukker <vlad@storewiz.com> Date: Wed, 21 Sep 2005 15:53:06 +0300 > I see you all agree to apply :) > > Stephen, repost of this patch to proper places below. Applied, but please learn how to send patches properly next time. Your email client mangled all the tab characters into spaces, so I had to add the patch by hand. I'm sure you can convince Evolution to not do that, or simply use attachments. Thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-09-23 6:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1127239659.12488.26.camel@quant>
[not found] ` <20050921.001427.27575173.davem@davemloft.net>
2005-09-21 12:53 ` [Bridge] Re: [PATCH] TSO fix in br_dev_queue_push_xmit Vlad Drukker
2005-09-21 16:47 ` Stephen Hemminger
2005-09-23 6:36 ` David S. Miller
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.