From: Rohit Seth <rohit.seth@intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Martin J. Bligh" <mbligh@mbligh.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Martin Hicks <mort@sgi.com>
Subject: Re: [PATCH] earlier allocation of order 0 pages from pcp in __alloc_pages
Date: Thu, 29 Sep 2005 18:58:25 -0700 [thread overview]
Message-ID: <1128045505.3735.31.camel@akash.sc.intel.com> (raw)
In-Reply-To: <20050929161118.27f9f1eb.akpm@osdl.org>
On Thu, 2005-09-29 at 16:11 -0700, Andrew Morton wrote:
> "Martin J. Bligh" <mbligh@mbligh.org> wrote:
> >
> > It looks like we're now dropping into direct reclaim as the first thing
> > in __alloc_pages before even trying to kick off kswapd. When the hell
> > did that start? Or is that only meant to trigger if we're already below
> > the low watermark level?
>
> That's all the numa goop which Martin Hicks added. It's all disabled if
> z->reclaim_pages is zero (it is). However we could be testing that flag a
> bit earlier, I think.
>
> And yeah, some de-spaghettification would be nice. Certainly before adding
> more logic.
>
> Martin, should we take out the early zone reclaim logic? It's all
> unreachable at present anyway.
>
...yeah just like sys_set_zone_reclaim. was it intended to be added as
a system call?
-rohit
WARNING: multiple messages have this Message-ID (diff)
From: Rohit Seth <rohit.seth@intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Martin J. Bligh" <mbligh@mbligh.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Martin Hicks <mort@sgi.com>
Subject: Re: [PATCH] earlier allocation of order 0 pages from pcp in __alloc_pages
Date: Thu, 29 Sep 2005 18:58:25 -0700 [thread overview]
Message-ID: <1128045505.3735.31.camel@akash.sc.intel.com> (raw)
In-Reply-To: <20050929161118.27f9f1eb.akpm@osdl.org>
On Thu, 2005-09-29 at 16:11 -0700, Andrew Morton wrote:
> "Martin J. Bligh" <mbligh@mbligh.org> wrote:
> >
> > It looks like we're now dropping into direct reclaim as the first thing
> > in __alloc_pages before even trying to kick off kswapd. When the hell
> > did that start? Or is that only meant to trigger if we're already below
> > the low watermark level?
>
> That's all the numa goop which Martin Hicks added. It's all disabled if
> z->reclaim_pages is zero (it is). However we could be testing that flag a
> bit earlier, I think.
>
> And yeah, some de-spaghettification would be nice. Certainly before adding
> more logic.
>
> Martin, should we take out the early zone reclaim logic? It's all
> unreachable at present anyway.
>
...yeah just like sys_set_zone_reclaim. was it intended to be added as
a system call?
-rohit
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-09-30 1:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-29 22:01 [PATCH] earlier allocation of order 0 pages from pcp in __alloc_pages Seth, Rohit
2005-09-29 22:01 ` Seth, Rohit
2005-09-29 22:36 ` Andrew Morton
2005-09-29 22:36 ` Andrew Morton
2005-09-30 1:05 ` Rohit Seth
2005-09-30 1:05 ` Rohit Seth
2005-09-29 22:48 ` Martin J. Bligh
2005-09-29 22:48 ` Martin J. Bligh
2005-09-29 23:11 ` Andrew Morton
2005-09-29 23:11 ` Andrew Morton
2005-09-30 1:58 ` Rohit Seth [this message]
2005-09-30 1:58 ` Rohit Seth
2005-09-30 12:30 ` Martin Hicks
2005-09-30 12:30 ` Martin Hicks
2005-09-30 1:32 ` Rohit Seth
2005-09-30 1:32 ` Rohit Seth
2005-09-30 1:32 ` Martin J. Bligh
2005-09-30 1:32 ` Martin J. Bligh
2005-09-29 22:50 ` Dave Hansen
2005-09-29 22:50 ` Dave Hansen
2005-09-30 1:10 ` Rohit Seth
2005-09-30 1:10 ` Rohit Seth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1128045505.3735.31.camel@akash.sc.intel.com \
--to=rohit.seth@intel.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mbligh@mbligh.org \
--cc=mort@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.