All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerone Young <jyoung5@us.ibm.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] Fix tools makefile to properly check for external tools
Date: Tue, 04 Oct 2005 14:04:41 -0500	[thread overview]
Message-ID: <1128452681.15111.14.camel@thinkpad> (raw)
In-Reply-To: <1128451606.15111.10.camel@thinkpad>

Ok ,thinking about the comment in tools/check/Makefile is so that one
could install stuff in "dist" directory. But our networking scripts have
no checks at all to see if (for example) "brctl" is even there...it just
silently installs. So given this when would one check that we have
everything need installed. Also I will submit a patch to add a check to
the network script to see if the tools are actually on the system.

On Tue, 2005-10-04 at 13:46 -0500, Jerone Young wrote:
> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
> 
> Fix tools makefile so that extrnal tools checks are run to ensure
> extrnal tools  are actually installed.
> 
> diff -r 00037ba13f0b -r cc75d51355cb tools/Makefile
> --- a/tools/Makefile    Tue Oct  4 17:23:58 2005
> +++ b/tools/Makefile    Tue Oct  4 16:28:18 2005
> @@ -33,7 +33,7 @@
>         done
>         $(MAKE) ioemu
> 
> -install: check
> +install: check_install
>         @set -e; for subdir in $(SUBDIRS); do \
>                 $(MAKE) -C $$subdir $@; \
>         done
> @@ -48,6 +48,9 @@
>  check:
>         $(MAKE) -C check
> 
> +check_install:
> +       $(MAKE) -C check install
> +
>  check_clean:
>         $(MAKE) -C check clean
> 
> 
-- 
Jerone Young
IBM Linux Technology Center
jyoung5@us.ibm.com
512-838-1157 (T/L: 678-1157)

  reply	other threads:[~2005-10-04 19:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-04 18:46 [PATCH] Fix tools makefile to properly check for external tools Jerone Young
2005-10-04 19:04 ` Jerone Young [this message]
2005-10-04 19:15   ` Nivedita Singhvi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1128452681.15111.14.camel@thinkpad \
    --to=jyoung5@us.ibm.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.